diff options
| author | Clément Chigot <clement.chigot@atos.net> | 2021-04-13 08:32:55 +0200 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2021-04-13 18:23:39 +0930 |
| commit | d2f1139ef0c006f35210fac76cb034cfe8d57c2e (patch) | |
| tree | a3df665f58341934b54f4d8b21005e3b54154a3b /bfd | |
| parent | 1cfc6f00e45104551da9146bb413b60acd0e387f (diff) | |
| download | gdb-d2f1139ef0c006f35210fac76cb034cfe8d57c2e.zip gdb-d2f1139ef0c006f35210fac76cb034cfe8d57c2e.tar.gz gdb-d2f1139ef0c006f35210fac76cb034cfe8d57c2e.tar.bz2 | |
bfd: avoid infinite loop when static linking XCOFF
git commit b95a0a3177bc changed a "return FALSE" to "continue", and
missed updating the while loop iterator.
* xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 4 | ||||
| -rw-r--r-- | bfd/xcofflink.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 28c5791..1603be8 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,7 @@ +2021-04-13 Clément Chigot <clement.chigot@atos.net> + + * xcofflink.c (xcoff_link_check_ar_symbols): Update esym earlier. + 2021-04-13 Nelson Chu <nelson.chu@sifive.com> * elfnn-riscv.c (riscv_version_mismatch): Do not report the warning diff --git a/bfd/xcofflink.c b/bfd/xcofflink.c index 8404862..f0e0fe7 100644 --- a/bfd/xcofflink.c +++ b/bfd/xcofflink.c @@ -2349,6 +2349,7 @@ xcoff_link_check_ar_symbols (bfd *abfd, struct internal_syment sym; bfd_coff_swap_sym_in (abfd, (void *) esym, (void *) &sym); + esym += (sym.n_numaux + 1) * symesz; if (EXTERN_SYM_P (sym.n_sclass) && sym.n_scnum != N_UNDEF) { @@ -2382,8 +2383,6 @@ xcoff_link_check_ar_symbols (bfd *abfd, return true; } } - - esym += (sym.n_numaux + 1) * symesz; } /* We do not need this object file. */ |