diff options
| author | Hans-Peter Nilsson <hp@axis.com> | 2012-04-24 16:09:12 +0000 |
|---|---|---|
| committer | Hans-Peter Nilsson <hp@axis.com> | 2012-04-24 16:09:12 +0000 |
| commit | 2758625139030bb7c1cdffcc99ce46a27d6ca0ce (patch) | |
| tree | 569785585bb86f753e862428694264adfd2f4d99 /bfd | |
| parent | f15f99484e2dd62e08e1200678c3919c8399adea (diff) | |
| download | gdb-2758625139030bb7c1cdffcc99ce46a27d6ca0ce.zip gdb-2758625139030bb7c1cdffcc99ce46a27d6ca0ce.tar.gz gdb-2758625139030bb7c1cdffcc99ce46a27d6ca0ce.tar.bz2 | |
PR ld/13990
* elf32-arm.c (elf32_arm_gc_sweep_hook): Handle a forced-local
symbol, where PLT refcount is set to -1.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elf32-arm.c | 15 |
2 files changed, 19 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 26c7a6c..b46eb9c 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2012-04-24 Hans-Peter Nilsson <hp@axis.com> + + PR ld/13990 + * elf32-arm.c (elf32_arm_gc_sweep_hook): Handle a forced-local + symbol, where PLT refcount is set to -1. + 2012-04-24 Alan Modra <amodra@gmail.com> PR ld/13991 diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c index 629e1f2..9560906 100644 --- a/bfd/elf32-arm.c +++ b/bfd/elf32-arm.c @@ -12256,8 +12256,19 @@ elf32_arm_gc_sweep_hook (bfd * abfd, if (may_need_local_target_p && elf32_arm_get_plt_info (abfd, eh, r_symndx, &root_plt, &arm_plt)) { - BFD_ASSERT (root_plt->refcount > 0); - root_plt->refcount -= 1; + /* If PLT refcount book-keeping is wrong and too low, we'll + see a zero value (going to -1) for the root PLT reference + count. */ + if (root_plt->refcount >= 0) + { + BFD_ASSERT (root_plt->refcount != 0); + root_plt->refcount -= 1; + } + else + /* A value of -1 means the symbol has become local, forced + or seeing a hidden definition. Any other negative value + is an error. */ + BFD_ASSERT (root_plt->refcount == -1); if (!call_reloc_p) arm_plt->noncall_refcount--; |