diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2019-04-17 09:08:46 -0700 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2019-04-17 09:08:46 -0700 |
| commit | 4e84a8f8bbeab52fa7048873655e582ceb92534d (patch) | |
| tree | c73326e0ce7c3d0cab5f06a57f94e73f8445a99b /bfd | |
| parent | e25de718de3b613cfafb9c5b28dea8e55a8649b8 (diff) | |
| download | gdb-4e84a8f8bbeab52fa7048873655e582ceb92534d.zip gdb-4e84a8f8bbeab52fa7048873655e582ceb92534d.tar.gz gdb-4e84a8f8bbeab52fa7048873655e582ceb92534d.tar.bz2 | |
x86: Also check x86 linker_def for non-shared definition
Since elf_x86_linker_defined sets linker_def in elf_x86_link_hash_entry
for linker defined symbols, SYMBOL_DEFINED_NON_SHARED_P should also check
linker_def in elf_x86_link_hash_entry.
bfd/
PR ld/24458
* elfxx-x86.h (SYMBOL_DEFINED_NON_SHARED_P): Also check x86
linker_def.
ld/
PR ld/24458
* testsuite/ld-x86-64/x86-64.exp: Run PR ld/24458 tests.
* testsuite/ld-x86-64/pr24458.s: New file.
* testsuite/ld-x86-64/pr24458a-x32.d: Likewise.
* testsuite/ld-x86-64/pr24458a.d: Likewise.
* testsuite/ld-x86-64/pr24458b-x32.d: Likewise.
* testsuite/ld-x86-64/pr24458b.d: Likewise.
* testsuite/ld-x86-64/pr24458c-x32.d: Likewise.
* testsuite/ld-x86-64/pr24458c.d: Likewise.
Diffstat (limited to 'bfd')
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elfxx-x86.h | 1 |
2 files changed, 7 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 834b84f..2d1c14f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2019-04-17 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/24458 + * elfxx-x86.h (SYMBOL_DEFINED_NON_SHARED_P): Also check x86 + linker_def. + 2019-04-15 Thomas Preud'homme <thomas.preudhomme@arm.com> * reloc.c (BFD_RELOC_ARM_T32_VLDR_VSTR_OFF_IMM): New internal diff --git a/bfd/elfxx-x86.h b/bfd/elfxx-x86.h index 013ac4b..57d6d6e 100644 --- a/bfd/elfxx-x86.h +++ b/bfd/elfxx-x86.h @@ -167,6 +167,7 @@ ((H)->def_regular \ || (H)->root.linker_def \ || (H)->root.ldscript_def \ + || ((struct elf_x86_link_hash_entry *) (H))->linker_def \ || ELF_COMMON_DEF_P (H)) /* TRUE if relative relocation should be generated. GOT reference to |