Touches most files in bfd/, so likely will be blamed for everything..

o  bfd_read and bfd_write lose an unnecessary param and become
   bfd_bread and bfd_bwrite.

o  bfd_*alloc now all take a bfd_size_type arg, and will error if
   size_t is too small.  eg. 32 bit host, 64 bit bfd, verrry big files
   or bugs in linker scripts etc.

o  file_ptr becomes a bfd_signed_vma.  Besides matching sizes with
   various other types involved in handling sections, this should make
   it easier for bfd to support a 64 bit off_t on 32 bit hosts that
   provide it.

o  I've made the H_GET_* and H_PUT_* macros (which invoke bfd_h_{get,put}_*)
   generally available.  They now cast their args to bfd_vma and
   bfd_byte * as appropriate, which removes a swag of casts from the
   source.

o  Bug fixes to bfd_get8, aix386_core_vec, elf32_h8_relax_section, and
   aout-encap.c.

o  Zillions of formatting and -Wconversion fixes.

1 files changed, 69 insertions, 63 deletions

diff --git a/bfd/riscix.c b/bfd/riscix.c
index 956ba47..bc560f2 100644
--- a/bfd/riscix.c
+++ b/bfd/riscix.c
@@ -55,19 +55,23 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
 #define N_SHARED_LIB(x) ((x).a_info & MF_USES_SL)
 
 /* Only a pure OMAGIC file has the minimal header */
-#define N_TXTOFF(x)                     \
- ((x).a_info == OMAGIC ? 32             \
-  : (N_MAGIC(x) == ZMAGIC) ? TARGET_PAGE_SIZE  \
-  : 999)
-
-#define N_TXTADDR(x)                                                         \
-  (N_MAGIC(x) != ZMAGIC ? 0 /* object file or NMAGIC */                      \
+#define N_TXTOFF(x)		\
+ ((x).a_info == OMAGIC		\
+  ? 32				\
+  : (N_MAGIC(x) == ZMAGIC	\
+     ? TARGET_PAGE_SIZE		\
+     : 999))
+
+#define N_TXTADDR(x)							     \
+  (N_MAGIC(x) != ZMAGIC							     \
+   ? (bfd_vma) 0 /* object file or NMAGIC */				     \
    /* Programs with shared libs are loaded at the first page after all the   \
       text segments of the shared library programs.  Without looking this    \
       up we can't know exactly what the address will be.  A reasonable guess \
-      is that a_entry will be in the first page of the executable.  */       \
-   : N_SHARED_LIB(x) ? ((x).a_entry & ~(TARGET_PAGE_SIZE - 1))                      \
-   : TEXT_START_ADDR)
+      is that a_entry will be in the first page of the executable.  */	     \
+   : (N_SHARED_LIB(x)							     \
+      ? ((x).a_entry & ~(bfd_vma) (TARGET_PAGE_SIZE - 1))		     \
+      : (bfd_vma) TEXT_START_ADDR))
 
 #define N_SYMOFF(x) \
   (N_TXTOFF (x) + (x).a_text + (x).a_data + (x).a_trsize + (x).a_drsize)
@@ -90,47 +94,47 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
 #include "sysdep.h"
 #include "libbfd.h"
 
-#define WRITE_HEADERS(abfd, execp)					   \
-  {									   \
-    bfd_size_type text_size; /* dummy vars */				   \
-    file_ptr text_end;							   \
-    if (adata(abfd).magic == undecided_magic)				   \
-      NAME(aout,adjust_sizes_and_vmas) (abfd, &text_size, &text_end);	   \
-    									   \
-    execp->a_syms = bfd_get_symcount (abfd) * EXTERNAL_NLIST_SIZE;	   \
-    execp->a_entry = bfd_get_start_address (abfd);			   \
-    									   \
-    execp->a_trsize = ((obj_textsec (abfd)->reloc_count) *		   \
-		       obj_reloc_entry_size (abfd));			   \
-    execp->a_drsize = ((obj_datasec (abfd)->reloc_count) *		   \
-		       obj_reloc_entry_size (abfd));			   \
-    NAME(aout,swap_exec_header_out) (abfd, execp, &exec_bytes);		   \
-    									   \
-    if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0) return false;	   \
-    if (bfd_write ((PTR) &exec_bytes, 1, EXEC_BYTES_SIZE, abfd)		   \
-	!= EXEC_BYTES_SIZE)						   \
-      return false;							   \
-    /* Now write out reloc info, followed by syms and strings */	   \
-									   \
-    if (bfd_get_outsymbols (abfd) != (asymbol **) NULL			   \
-	&& bfd_get_symcount (abfd) != 0)				   \
-      {									   \
+#define WRITE_HEADERS(abfd, execp)					    \
+  {									    \
+    bfd_size_type text_size; /* dummy vars */				    \
+    file_ptr text_end;							    \
+    if (adata(abfd).magic == undecided_magic)				    \
+      NAME(aout,adjust_sizes_and_vmas) (abfd, &text_size, &text_end);	    \
+    									    \
+    execp->a_syms = bfd_get_symcount (abfd) * EXTERNAL_NLIST_SIZE;	    \
+    execp->a_entry = bfd_get_start_address (abfd);			    \
+    									    \
+    execp->a_trsize = ((obj_textsec (abfd)->reloc_count) *		    \
+		       obj_reloc_entry_size (abfd));			    \
+    execp->a_drsize = ((obj_datasec (abfd)->reloc_count) *		    \
+		       obj_reloc_entry_size (abfd));			    \
+    NAME(aout,swap_exec_header_out) (abfd, execp, &exec_bytes);		    \
+    									    \
+    if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0			    \
+	|| bfd_bwrite ((PTR) &exec_bytes, (bfd_size_type) EXEC_BYTES_SIZE,   \
+		      abfd) != EXEC_BYTES_SIZE)				    \
+      return false;							    \
+    /* Now write out reloc info, followed by syms and strings */	    \
+									    \
+    if (bfd_get_outsymbols (abfd) != (asymbol **) NULL			    \
+	&& bfd_get_symcount (abfd) != 0)				    \
+      {									    \
 	if (bfd_seek (abfd, (file_ptr) (N_SYMOFF(*execp)), SEEK_SET) != 0)  \
-	  return false;							   \
-									   \
-	if (! NAME(aout,write_syms) (abfd)) return false;		   \
-									   \
+	  return false;							    \
+									    \
+	if (! NAME(aout,write_syms) (abfd)) return false;		    \
+									    \
 	if (bfd_seek (abfd, (file_ptr) (N_TRELOFF(*execp)), SEEK_SET) != 0) \
-	  return false;							   \
-									   \
-	if (! riscix_squirt_out_relocs (abfd, obj_textsec (abfd)))	   \
-	  return false;							   \
+	  return false;							    \
+									    \
+	if (! riscix_squirt_out_relocs (abfd, obj_textsec (abfd)))	    \
+	  return false;							    \
 	if (bfd_seek (abfd, (file_ptr) (N_DRELOFF(*execp)), SEEK_SET) != 0) \
-	  return false;							   \
-									   \
-	if (!NAME(aout,squirt_out_relocs) (abfd, obj_datasec (abfd)))	   \
-	  return false;							   \
-      }									   \
+	  return false;							    \
+									    \
+	if (!NAME(aout,squirt_out_relocs) (abfd, obj_datasec (abfd)))	    \
+	  return false;							    \
+      }									    \
   }
 
 #include "libaout.h"
@@ -240,12 +244,12 @@ riscix_fix_pcrel_26 (abfd, reloc_entry, symbol, data, input_section,
       if ((relocation & ~ (bfd_vma) 0x03ffffff) != ~ (bfd_vma) 0x03ffffff)
 	flag = bfd_reloc_overflow;
     }
-  else if (relocation & ~0x03ffffff)
+  else if (relocation & ~ (bfd_vma) 0x03ffffff)
     flag = bfd_reloc_overflow;
 
   target &= ~0x00ffffff;
   target |= (relocation >> 2) & 0x00ffffff;
-  bfd_put_32 (abfd, target, (bfd_byte *) data + addr);
+  bfd_put_32 (abfd, (bfd_vma) target, (bfd_byte *) data + addr);
 
   /* Now the ARM magic... Change the reloc type so that it is marked as done.
      Strictly this is only necessary if we are doing a partial relocation.  */
@@ -399,12 +403,13 @@ riscix_squirt_out_relocs (abfd, section)
   size_t each_size;
 
   unsigned int count = section->reloc_count;
-  size_t natsize;
+  bfd_size_type natsize;
 
   if (count == 0) return true;
 
   each_size = obj_reloc_entry_size (abfd);
-  natsize = each_size * count;
+  natsize = each_size;
+  natsize *= count;
   native = (unsigned char *) bfd_zalloc (abfd, natsize);
   if (!native)
     return false;
@@ -417,9 +422,9 @@ riscix_squirt_out_relocs (abfd, section)
     riscix_swap_std_reloc_out (abfd, *generic,
 			       (struct reloc_std_external *) natptr);
 
-  if ( bfd_write ((PTR) native, 1, natsize, abfd) != natsize)
+  if (bfd_bwrite ((PTR) native, natsize, abfd) != natsize)
     {
-      bfd_release(abfd, native);
+      bfd_release (abfd, native);
       return false;
     }
 
@@ -488,9 +493,9 @@ riscix_some_aout_object_p (abfd, execp, callback_to_real_object_p)
 {
   struct aout_data_struct *rawptr, *oldrawptr;
   const bfd_target *result;
+  bfd_size_type amt = sizeof (struct aout_data_struct);
 
-  rawptr = ((struct aout_data_struct  *)
-	    bfd_zalloc (abfd, sizeof (struct aout_data_struct )));
+  rawptr = (struct aout_data_struct  *) bfd_zalloc (abfd, amt);
 
   if (rawptr == NULL)
     return 0;
@@ -632,14 +637,15 @@ MY(object_p) (abfd)
   struct internal_exec exec;            /* Cleaned-up exec header */
   const bfd_target *target;
 
-  if (bfd_read ((PTR) &exec_bytes, 1, EXEC_BYTES_SIZE, abfd)
-      != EXEC_BYTES_SIZE) {
-    if (bfd_get_error () != bfd_error_system_call)
-      bfd_set_error (bfd_error_wrong_format);
-    return 0;
-  }
+  if (bfd_bread ((PTR) &exec_bytes, (bfd_size_type) EXEC_BYTES_SIZE, abfd)
+      != EXEC_BYTES_SIZE)
+    {
+      if (bfd_get_error () != bfd_error_system_call)
+	bfd_set_error (bfd_error_wrong_format);
+      return 0;
+    }
 
-  exec.a_info = bfd_h_get_32 (abfd, exec_bytes.e_info);
+  exec.a_info = H_GET_32 (abfd, exec_bytes.e_info);
 
   if (N_BADMAG (exec)) return 0;
 #ifdef MACHTYPE_OK