aboutsummaryrefslogtreecommitdiff
path: root/bfd/peXXigen.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2018-10-16 15:23:20 +1030
committerAlan Modra <amodra@gmail.com>2018-10-16 16:41:57 +1030
commit8df73d5cc3a87101f3bd254f33820fcce61bc971 (patch)
treec0ac1672e1a4b7277145d88505f04f6ce342f208 /bfd/peXXigen.c
parentfeceaa596ebd1da9d8315c8ce74e45df4384da15 (diff)
downloadgdb-8df73d5cc3a87101f3bd254f33820fcce61bc971.zip
gdb-8df73d5cc3a87101f3bd254f33820fcce61bc971.tar.gz
gdb-8df73d5cc3a87101f3bd254f33820fcce61bc971.tar.bz2
PR23781, _bfd_pe_bfd_copy_private_bfd_data_common memory leak
PR 23781 * peXXigen.c (_bfd_XX_bfd_copy_private_bfd_data_common): Free data before returning.
Diffstat (limited to 'bfd/peXXigen.c')
-rw-r--r--bfd/peXXigen.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/bfd/peXXigen.c b/bfd/peXXigen.c
index 1645ef4..1271d4e 100644
--- a/bfd/peXXigen.c
+++ b/bfd/peXXigen.c
@@ -2993,6 +2993,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
"exceeds space left in section (%" PRIx64 ")"),
obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size,
(uint64_t) (section->size - (addr - section->vma)));
+ free (data);
return FALSE;
}
/* PR 23110. */
@@ -3002,6 +3003,7 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
_bfd_error_handler
(_("%pB: Data Directory size (%#lx) is negative"),
obfd, ope->pe_opthdr.DataDirectory[PE_DEBUG_DATA].Size);
+ free (data);
return FALSE;
}
@@ -3030,8 +3032,10 @@ _bfd_XX_bfd_copy_private_bfd_data_common (bfd * ibfd, bfd * obfd)
if (!bfd_set_section_contents (obfd, section, data, 0, section->size))
{
_bfd_error_handler (_("failed to update file offsets in debug directory"));
+ free (data);
return FALSE;
}
+ free (data);
}
else if (section)
{