diff options
| author | Nick Clifton <nickc@redhat.com> | 2008-02-20 17:42:36 +0000 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2008-02-20 17:42:36 +0000 |
| commit | 515ef31dec50185cc5d8a6f88b51832bfd259e87 (patch) | |
| tree | 3b25393193afaf4f670cf6da64ff323faee10203 /bfd/mach-o.c | |
| parent | 4443cd0f6e76d3ecb793814445d2e01b41f29fbe (diff) | |
| download | gdb-515ef31dec50185cc5d8a6f88b51832bfd259e87.zip gdb-515ef31dec50185cc5d8a6f88b51832bfd259e87.tar.gz gdb-515ef31dec50185cc5d8a6f88b51832bfd259e87.tar.bz2 | |
PR 868
* libbfd.c (bfd_realloc_or_free): New function. Performs like
bfd_realloc, but if the (re)allocation fails, the pointer is
freed.
* libbfd-in.h: Prototype.
* libbfd.h: Regenerate.
* bfdio.c (bfd_bwrite): Use the new function.
(bfd_seek): Likewise.
* bfdwin.c:(bfd_get_file_window): Likewise.
* elf-strtab.c (_bfd_elf_strtab_add): Likewise.
* elf32-ppc.c (ppc_elf_relax_section): Likewise.
* elf32-xtensa.c (vsprintf_msg): Likewise.
* mach-o.c (bfd_mach_o_core_fetch_environment): Likewise.
* stabs.c (_bfd_link_seciton_stabs): Likewise.
* vms-misc.c (_bfd_vms_get_record): Likewise.
* vms-tir.c (check_section): Likewise.
* vms.c (vms_new_section_hook): Likewise.
* elf32-arm.c (elf32_arm_section_map_add): Check that the
allocation of sec_data->map succeeded before using it.
* elflink.c (elf_link_output_sym): Do not overwrite finfo->
symshndxbuf until it is known that the reallocation succeeded.
Diffstat (limited to 'bfd/mach-o.c')
| -rw-r--r-- | bfd/mach-o.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/bfd/mach-o.c b/bfd/mach-o.c index 166dd65..bde89b0 100644 --- a/bfd/mach-o.c +++ b/bfd/mach-o.c @@ -1,5 +1,5 @@ /* Mach-O support for BFD. - Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007 + Copyright 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc. This file is part of BFD, the Binary File Descriptor library. @@ -1923,13 +1923,18 @@ bfd_mach_o_core_fetch_environment (bfd *abfd, if (size > (end - start)) size = (end - start); - buf = bfd_realloc (buf, size); - + buf = bfd_realloc_or_free (buf, size); + if (buf == NULL) + return -1; + bfd_seek (abfd, end - size, SEEK_SET); nread = bfd_bread (buf, size, abfd); if (nread != size) - return -1; + { + free (buf); + return -1; + } for (offset = 4; offset <= size; offset += 4) { @@ -1952,6 +1957,7 @@ bfd_mach_o_core_fetch_environment (bfd *abfd, *rlen = top - bottom; memcpy (*rbuf, buf + size - *rlen, *rlen); + free (buf); return 0; } } @@ -1961,6 +1967,8 @@ bfd_mach_o_core_fetch_environment (bfd *abfd, size *= 2; } + + free (buf); } } |