diff options
| author | Alan Modra <amodra@gmail.com> | 2014-04-24 21:59:56 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2014-04-24 22:04:05 +0930 |
| commit | 93ee1e3683a12f4774b8beb4f821910982e21ce2 (patch) | |
| tree | b98ee67b8b76663f5e048a0188aaa1835f4d830b /bfd/libbfd-in.h | |
| parent | aaca88efb450bff71523d7d6f23a67f47a4d5fb3 (diff) | |
| download | gdb-93ee1e3683a12f4774b8beb4f821910982e21ce2.zip gdb-93ee1e3683a12f4774b8beb4f821910982e21ce2.tar.gz gdb-93ee1e3683a12f4774b8beb4f821910982e21ce2.tar.bz2 | |
PR16867, linking object with separate debug file
This teaches the DWARF2 find_line functions how to deal with separate
debug relocatable object files. Also fixes a major bug:
When _bfd_dwarf2_slurp_debug_info was split out, place_sections ran
after .debug_info was relocated. This defeated the whole purpose of
place_sections. See the comment I added before place_sections.
Fixes some minor bugs too:
- place_sections didn't set VMA for alloc but non-load sections (bss).
- zero size sections can have symbols, so they need their VMA set too.
- last_vma was incorrectly adjusted.
- my last change to place_sections left VMA unchanged for .debug_info
when the linker has mapped input to output sections, but this is
wrong since bfd_simple_get_relocated_section_contents unmaps debug
sections.
PR 16867
* dwarf2.c: Formatting.
(struct dwarf2_debug): Make adjusted_section_count signed.
(unset_sections): Make i signed.
(set_debug_vma): New function.
(place_sections): Handle separate debug object file. Set VMA
on debug sections, even if they have an output section. Also
set VMA on zero size sections, and non-load but alloc sections.
Set adjusted_section_count to -1 when no section adjustment.
Malloc adjusted_sections. Don't double last_vma. Transfer
alloc section VMAs to separate debug file.
(_bfd_dwarf2_cleanup_debug_info): Free adjusted_sections.
(_bfd_dwarf2_slurp_debug_info): Add do_place parameter. Drop
test on symbols being the same before using old stash. Read
and use separate debug file symbols. Call place_sections.
(find_line): Don't call place_sections here.
* libbfd-in.h (_bfd_dwarf2_slurp_debug_info): Update proto.
* libbfd.h: Regenerate.
* mach-o.c (bfd_mach_o_find_nearest_line): Adjust
_bfd_dwarf2_slurp_debug_info call.
* simple.c (simple_save_output_info): Clarify comment.
Diffstat (limited to 'bfd/libbfd-in.h')
| -rw-r--r-- | bfd/libbfd-in.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bfd/libbfd-in.h b/bfd/libbfd-in.h index 62804af..8a4f439 100644 --- a/bfd/libbfd-in.h +++ b/bfd/libbfd-in.h @@ -560,7 +560,8 @@ extern bfd_boolean _bfd_dwarf2_find_inliner_info /* Read DWARF 2 debugging information. */ extern bfd_boolean _bfd_dwarf2_slurp_debug_info - (bfd *, bfd *, const struct dwarf_debug_section *, asymbol **, void **); + (bfd *, bfd *, const struct dwarf_debug_section *, asymbol **, void **, + bfd_boolean); /* Clean up the data used to handle DWARF 2 debugging information. */ extern void _bfd_dwarf2_cleanup_debug_info |