diff options
| author | Alan Modra <amodra@gmail.com> | 2022-11-23 22:12:30 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2022-11-23 22:38:48 +1030 |
| commit | e6b6fad2fe4d180bcd65a1e0aabc6ba763901346 (patch) | |
| tree | bc1ceb0e32d8f6a15365185e2947bc6d724dd0e0 /bfd/i386lynx.c | |
| parent | d499fb89448c3f2e061813f12a1b63fbaa29422e (diff) | |
| download | gdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.zip gdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.tar.gz gdb-e6b6fad2fe4d180bcd65a1e0aabc6ba763901346.tar.bz2 | |
PR22509 - Null pointer dereference on coff_slurp_reloc_table
This extends the commit 4581a1c7d304 fix to more targets, which
hardens BFD a little. I think the real underlying problem was the
bfd_canonicalize_reloc call in load_specific_debug_section which
passed a NULL for "symbols". Fix that too.
PR 22509
bfd/
* aoutx.h (swap_ext_reloc_out): Gracefully handle NULL symbols.
* i386lynx.c (swap_ext_reloc_out): Likewise.
* pdp11.c (pdp11_aout_swap_reloc_out): Likewise.
* coff-tic30.c (reloc_processing): Likewise.
* coff-tic4x.c (tic4x_reloc_processing): Likewise.
* coff-tic54x.c (tic54x_reloc_processing): Likewise.
* coff-z80.c (reloc_processing): Likewise.
* coff-z8k.c (reloc_processing): Likewise.
* ecoff.c (ecoff_slurp_reloc_table): Likewise.
* som.c (som_set_reloc_info): Likewise.
binutils/
* objdump.c (load_specific_debug_section): Pass syms to
bfd_canonicalize_reloc.
Diffstat (limited to 'bfd/i386lynx.c')
| -rw-r--r-- | bfd/i386lynx.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/bfd/i386lynx.c b/bfd/i386lynx.c index 5df3d19..acc38d2 100644 --- a/bfd/i386lynx.c +++ b/bfd/i386lynx.c @@ -283,8 +283,10 @@ NAME(lynx,swap_ext_reloc_out) (bfd *abfd, if (r_extern) \ { \ /* undefined symbol */ \ - if (r_index < bfd_get_symcount (abfd)) \ + if (symbols != NULL && r_index < bfd_get_symcount (abfd)) \ cache_ptr->sym_ptr_ptr = symbols + r_index; \ + else \ + cache_ptr->sym_ptr_ptr = bfd_abs_section_ptr->symbol_ptr_ptr; \ cache_ptr->addend = ad; \ } \ else \ |