diff options
| author | Alan Modra <amodra@gmail.com> | 2024-02-15 19:03:07 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-02-15 19:11:42 +1030 |
| commit | 313f04b6edcd09e0e7ff224bd54a892ab8f029aa (patch) | |
| tree | b7a16c713a410489aeec144fb73106b193d10254 /bfd/elfnn-kvx.c | |
| parent | d88a48558d6dc171fccb4c5c496c9248e78eecd0 (diff) | |
| download | gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.zip gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.tar.gz gdb-313f04b6edcd09e0e7ff224bd54a892ab8f029aa.tar.bz2 | |
Re: elf_backend_finish_dynamic_symbol returning false
I didn't examine ld testsuite logs properly after cf95b909e2c2.
Replacing one of the "return false" with BFD_ASSERT in
finish_dynamic_symbol was wrong as it causes segmentation faults on
testcases expected to fail. Revert those changes and instead make
a bfd_final_link failure noisy.
Diffstat (limited to 'bfd/elfnn-kvx.c')
| -rw-r--r-- | bfd/elfnn-kvx.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bfd/elfnn-kvx.c b/bfd/elfnn-kvx.c index 00446c9..ae5ed6b 100644 --- a/bfd/elfnn-kvx.c +++ b/bfd/elfnn-kvx.c @@ -4479,7 +4479,8 @@ elfNN_kvx_finish_dynamic_symbol (bfd *output_bfd, if (bfd_link_pic (info) && SYMBOL_REFERENCES_LOCAL (info, h)) { - BFD_ASSERT (h->def_regular); + if (!h->def_regular) + return false; /* in case of PLT related GOT entry, it is not clear who is supposed to set the LSB of GOT entry... |