diff options
| author | Alan Modra <amodra@gmail.com> | 2017-10-28 14:10:55 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2017-10-28 22:11:40 +1030 |
| commit | c0e331c794d6bd75d9be9bea6145513074c33f39 (patch) | |
| tree | 6f6ad19925ad01938e4429d3fbdd9c3328909b3f /bfd/elflink.c | |
| parent | bac608e7e11fa83a648c0980883f810ebd1874b1 (diff) | |
| download | gdb-c0e331c794d6bd75d9be9bea6145513074c33f39.zip gdb-c0e331c794d6bd75d9be9bea6145513074c33f39.tar.gz gdb-c0e331c794d6bd75d9be9bea6145513074c33f39.tar.bz2 | |
PR22300, Abort in elf32_hppa_relocate_section building polyml
polyml produces object files with the wrong OS/ABI for hppa-linux.
This, along with the fact that elf32-hppa.c is using the strictest
backend relocs_compatible, results in wrong merging of ELF symbols.
So, remove the relocs_compatible check in _bfd_elf_merge_symbol.
_bfd_elf_merge_symbol is only called nowadays from within blocks
protected by is_elf_hash_table, so "we are doing an ELF link" as the
removed comment says, is true.
Also relax relocs_compatible for hppa and powerpc. relocs_compatible
is used for more than just merging symbols, as the name suggests.
This allows objects that are in fact reasonably compatible to be
linked.
PR 22300
* elflink.c (_bfd_elf_merge_symbol): Remove relocs_compatible check.
* elf32-hppa.c (elf_backend_relocs_compatible): Define.
* elf32-ppc.c (elf_backend_relocs_compatible): Define.
* elf64-ppc.c (elf_backend_relocs_compatible): Define.
Diffstat (limited to 'bfd/elflink.c')
| -rw-r--r-- | bfd/elflink.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/bfd/elflink.c b/bfd/elflink.c index 20057f5..9f2d63b 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -1162,11 +1162,6 @@ _bfd_elf_merge_symbol (bfd *abfd, if (pold_weak) *pold_weak = oldweak; - /* This code is for coping with dynamic objects, and is only useful - if we are doing an ELF link. */ - if (!(*bed->relocs_compatible) (abfd->xvec, info->output_bfd->xvec)) - return TRUE; - /* We have to check it for every instance since the first few may be references and not all compilers emit symbol type for undefined symbols. */ |