aboutsummaryrefslogtreecommitdiff
path: root/bfd/elf64-ppc.c
diff options
context:
space:
mode:
authorAlan Modra <amodra@gmail.com>2017-11-14 11:02:57 +1030
committerAlan Modra <amodra@gmail.com>2017-11-14 15:45:41 +1030
commit2d0d44d514d9a2e2b0f7ae8129d52b02160c9897 (patch)
treefd17d0d0242fa20fb405dc44032fa10042172eed /bfd/elf64-ppc.c
parentddbb44cf366b652dc9edf2ccd4605f1ed0e2e62d (diff)
downloadgdb-2d0d44d514d9a2e2b0f7ae8129d52b02160c9897.zip
gdb-2d0d44d514d9a2e2b0f7ae8129d52b02160c9897.tar.gz
gdb-2d0d44d514d9a2e2b0f7ae8129d52b02160c9897.tar.bz2
Inconsistent .eh_frame_hdr on powerpc64
There is code in bfd/elf-eh-frame.c and ld/emultempl/elf32.em that checks for the presence of eh_frame info by testing for a section named .eh_frame sized more than 8 bytes. The size test is to exclude a zero terminator. A similar check in elf64-ppc.c wrongly just tested for non-zero size before creating the linker generated .eh_frame describing plt call and other linkage stubs. The intention was to not generate that info unless there was some user .eh_frame. (No user .eh_frame implies the user doesn't care about exception handling.) Because the test in elf64-ppc.c was wrong, ld generated the stub .eh_frame just on finding a zero .eh_frame terminator in crtend.o, but didn't generate the corresponding .eh_frame_hdr. * elf64-ppc.c (ppc64_elf_size_stubs): Correct test for user .eh_frame info.
Diffstat (limited to 'bfd/elf64-ppc.c')
-rw-r--r--bfd/elf64-ppc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 181bbdc..31ee412 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -12700,7 +12700,7 @@ ppc64_elf_size_stubs (struct bfd_link_info *info)
if (htab->glink_eh_frame != NULL
&& !bfd_is_abs_section (htab->glink_eh_frame->output_section)
- && htab->glink_eh_frame->output_section->size != 0)
+ && htab->glink_eh_frame->output_section->size > 8)
{
size_t size = 0, align = 4;