diff options
| author | H.J. Lu <hjl.tools@gmail.com> | 2005-02-06 18:11:30 +0000 |
|---|---|---|
| committer | H.J. Lu <hjl.tools@gmail.com> | 2005-02-06 18:11:30 +0000 |
| commit | 90f487dfe075092afbd0be376bd3c1cd5cfb8276 (patch) | |
| tree | e9afc5d1b623ce6255fe1f5428d78c502d2a6ad0 /bfd/elf32-i386.c | |
| parent | 5b90c7b5ebca2697d381a2da54383662b47874bb (diff) | |
| download | gdb-90f487dfe075092afbd0be376bd3c1cd5cfb8276.zip gdb-90f487dfe075092afbd0be376bd3c1cd5cfb8276.tar.gz gdb-90f487dfe075092afbd0be376bd3c1cd5cfb8276.tar.bz2 | |
2005-02-06 H.J. Lu <hongjiu.lu@intel.com>
* elf32-i386.c (elf_i386_relocate_section): Disallow R_386_GOTOFF
against protected function when building shared library.
PR 584
* elf64-x86-64.c (is_32bit_relative_branch): New.
(elf64_x86_64_relocate_section): Alllow R_X86_64_PC32 on a
protected function symbol when building shared library for
32bit relative branch instruction.
Diffstat (limited to 'bfd/elf32-i386.c')
| -rw-r--r-- | bfd/elf32-i386.c | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/bfd/elf32-i386.c b/bfd/elf32-i386.c index 4785552..9bab9be 100644 --- a/bfd/elf32-i386.c +++ b/bfd/elf32-i386.c @@ -2274,6 +2274,22 @@ elf_i386_relocate_section (bfd *output_bfd, /* Relocation is relative to the start of the global offset table. */ + /* Check to make sure it isn't a protected function symbol + for shared library since it may not be local when used + as function address. */ + if (info->shared + && h + && h->def_regular + && h->type == STT_FUNC + && ELF_ST_VISIBILITY (h->other) == STV_PROTECTED) + { + (*_bfd_error_handler) + (_("%B: relocation R_386_GOTOFF against protected function `%s' can not be used when making a shared object"), + input_bfd, h->root.root.string); + bfd_set_error (bfd_error_bad_value); + return FALSE; + } + /* Note that sgot is not involved in this calculation. We always want the start of .got.plt. If we defined _GLOBAL_OFFSET_TABLE_ in a different way, as is |