Make all callers of malloc or realloc (including via obstacks)

	check the result for NULL.  Most set bfd_error to no_memory and
	return in that case; a few are harder to fix, and are marked
	with "FIXME <return type>".

	* elf32-hppa.c (hppa_elf_build_arg_reloc_stub
	hppa_elf_build_long_branch_stub):  Check bfd_make_empty_symbol return.
	* linker.c (_bfd_generic_link_output_symbols
	_bfd_generic_link_write_global_symbol): Ditto
	* section.c (bfd_make_section_anyway): Ditto.

	* tekhex.c (find_chunk tekhex_mkobject): Check bfd_alloc.
	(first_phase): Ditto.  FIXME void
	(tekhex_make_empty_symbol): Check bfd_zalloc.

	* sunos.c (sunos_read_dynamic_info): Check bfd_zalloc.
	(MY(read_dynamic_symbols) MY(read_dynamic_relocs)): Check bfd_alloc.

	* stringhash.c (_bfd_stringtab_hash_newfunc): Check bfd_hash_allocate.

	* srec.c: Indent.
	(fillup_symbols): Check bfd_alloc.  FIXME void
	(srec_mkobject srec_get_section_contents
	srec_set_section_contents): Check bfd_alloc.
	(srec_make_empty_symbol): Check bfd_zalloc.

	* som.c (hppa_som_gen_reloc_type): Check bfd_alloc_by_size_t.
	(make_unique_section): Check bfd_alloc.
	(som_new_section_hook): Check bfd_zalloc.
	(bfd_som_attach_aux_hdr): Ditto.  FIXME void

	* rs6000-core.c (rs6000coff_core_p): Check bfd_zalloc.

	* osf-core.c (osf_core_make_empty_symbol): Check bfd_zalloc.
	(osf_core_core_file_p): Check bfd_alloc.

	* oasys.c (oasys_slurp_symbol_table oasys_archive_p
	oasys_mkobject oasys_object_p oasys_new_section_hook
	oasys_set_section_contents): Check bfd_alloc.
	(oasys_slurp_section_data): Check bfd_zalloc and bfd_alloc.
	(oasys_make_empty_symbol): Check bfd_zalloc.

	* nlmcode.h (nlm_make_empty_symbol): Check bfd_zalloc.
	(nlm_slurp_symbol_table): Check bfd_zalloc and bfd_alloc.

	* nlm32-sparc.c (nlm_sparc_read_import): Check bfd_alloc.

	* nlm32-i386.c (nlm_i386_read_import): Check bfd_alloc.

	* nlm32-alpha.c (nlm_alpha_read_import): Check bfd_alloc.

	* linker.c (_bfd_link_hash_newfunc
	(generic_link_hash_newfunc
	(archive_hash_newfunc
	(_bfd_generic_link_add_one_symbol): Check bfd_hash_allocate.
	(_bfd_generic_final_link
	(_bfd_generic_link_output_symbols
	(default_indirect_link_order): Check bfd_alloc.
	(bfd_new_link_order): Check bfd_alloc_by_size_t.

	* irix-core.c (irix_core_make_empty_symbol): Check bfd_zalloc.

	* ieee.c: Indent.
	(read_id get_symbol get_section_entry ieee_archive_p ieee_object_p
	ieee_slurp_section_data ieee_new_section_hook): Check bfd_alloc.
	(do_one): Check bfd_alloc.  Return a boolean.
	(ieee_slurp_section_data): Check it.
	(init_for_output): Check bfd_alloc.  Return a boolean.
	(ieee_set_section_contents): Check it.
	(do_with_relocs):  Check bfd_alloc.  Return a boolean.
	(ieee_bfd_debug_info_accumulate): Ditto.  FIXME void.
	(ieee_mkobject): Check bfd_zalloc.
	(ieee_make_empty_symbol): Check bfd_zmalloc.

	* hpux-core.c (hpux_core_make_empty_symbol): Check
	bfd_zalloc.

	* hppabsd-core.c (hppabsd_core_make_empty_symbol): Check
	bfd_zalloc.
	(hppabsd_core_core_file_p): Check bfd_zalloc.

	* hp300hpux.c (MY(slurp_symbol_table)): Check bfd_alloc.

	* elfcode.h (elf_new_section_hook): Check bfd_alloc.
	(bfd_section_from_phdr): Ditto.
	(write_relocs): Ditto.  FIXME void
	(elf_map_symbols assign_section_numbers map_program_segments):
	Ditto.  Return a boolean.
	(swap_out_syms): Ditto.  Check elf_map_symbols.
	(elf_slurp_symbol_table): Check bfd_zalloc.
	(elf_slurp_reloca_table): Check bfd_alloc.
	(elf_slurp_reloc_table): Ditto.
	(elf_compute_section_file_positions): Check assign_section_numbers.
	(assign_file_positions_except_relocs): Return a boolean.
	Check map_program_segments.
	(elf_compute_section_file_positions): Check it.

	* elf32-mips.c (mips_elf_final_link): Check bfd_alloc.

	* elf32-hppa.c (hppa_elf_stub_branch_reloc): Check bfd_zmalloc and
	realloc.
	(hppa_elf_stub_reloc): Ditto.
	(hppa_elf_build_arg_reloc_stub): Check bfd_zalloc.
	(hppa_elf_build_long_branch_stub): Ditto.
	(elf32_hppa_backend_symbol_table_processing): Ditto.

	* ecoff.c (ecoff_set_symbol_info): Check bfd_alloc.  Return a boolean.
	(ecoff_slurp_symbol_table): Check it.
	(ecoff_slurp_armap): Check bfd_alloc.
	(ecoff_write_armap): Check bfd_zalloc.
	(ecoff_link_hash_newfunc): Check bfd_hash_allocate and
	_bfd_link_hash_newfunc.
	(ecoff_link_add_externals): Check bfd_alloc.

	* ctor.c (bfd_constructor_entry): Check bfd_alloc.

	* coffgen.c (coff_real_object_p): Check bfd_alloc.
	(coff_renumber_symbols): Check bfd_alloc_by_size_t.  Return a boolean.
	(coff_write_symbol): Check bfd_alloc.  FIXME int
	(coff_write_linenumbers): Check bfd_alloc.  Return a boolean.
	(coff_section_symbol): Check bfd_alloc_by_size_t.
	(coff_get_normalized_symtab): Check bfd_alloc.
	(coff_bfd_make_debug_symbol): Check bfd_zalloc.
	* libcoff-in.h: Change decls of coff_renumber_symbols,
	coff_write_linenumbers.
	* libcoff.h: Rebuilt.
	* coffcode.h (coff_write_object_contents): Check
	coff_renumber_symbols, coff_write_linenumbers.

	* coffcode.h: Indent.
	(coff_add_missing_symbols): Check bfd_alloc_by_size_t.  Return a
	boolean.
	(coff_write_object_contents): Check it.

	* coff-alpha.c (alpha_relocate_section): Check bfd_alloc.
	* coff-mips.c (mips_relocate_section): Ditto.

	* archive.c (bfd_slurp_bsd_armap_f2): Check bfd_alloc value.
	(do_slurp_bsd_armap): Ditto.
	(compute_and_write_armap): Check bfd_realloc value.

	* aoutx.h (translate_from_native_sym_flags): Check bfd_alloc
	return value.  Return boolean value.
	(NAME(aout,make_empty_symbol)): Check bfd_zalloc return value.
	(NAME(aout,slurp_symbol_table)): Check bf_alloc and bfd_zalloc
	return value.
	(add_to_stringtab): Ditto.  FIXME void
	(aout_link_hash_newfunc): Check bfd_hash_allocate return value.
	(aout_link_add_symbols): Check bfd_alloc value.
	(translate_symbol_table): Check translate_from_native_sym_flags.
	* hp300hpux.c (MY(slurp_symbol_table)): Ditto.
	* aoutx.h (aout_link_hash_newfunc): Check _bfd_link_hash_newfunc.

	* opncls.c (bfd_zalloc bfd_realloc): Check result of bfd_alloc.

	* opncls.c (obstack_chunk_alloc): Define as malloc, not
	bfd_xmalloc_by_size_t.
	(_bfd_new_bfd): Check obstack_begin for 0 return.

	* ieee.c (obstack_chunk_alloc): Define as malloc, not
	bfd_xmalloc_by_size_t.
	(ieee_archive_p): Check obstack_begin for 0 return and
	obstack_finish for NULL return.

	* hash.c (obstack_chunk_alloc): Define as malloc, not
	bfd_xmalloc_by_size_t.
	(bfd_hash_table_init_n): Check obstack_begin for 0 return and
	obstack_finish for NULL return.
	(bfd_hash_lookup): Check obstack_alloc for NULL return.

	* ecofflink.c (obstack_chunk_alloc): Define as malloc, not
	bfd_xmalloc_by_size_t.
	bfd_ecoff_debug_accumulate
	bfd_ecoff_debug_accumulate_other): Check obstack_alloc.
	(add_file_shuffle add_memory_shuffle): Check obstack_alloc for
	NULL return.  Return boolean, not void.
	(bfd_ecoff_debug_init): Check obstack_begin for 0 return.
	(bfd_ecoff_debug_accumulate): Check add_file_shuffle
	and add_memory_shuffle return.
	(string_hash_newfunc): Check bfd_hash_allocate and bfd_hash_newfunc.
	(bfd_ecoff_debug_accumulate): Check bfd_alloc.
	(ecoff_add_string): Check add_memory_shuffle return.

	* libbfd-in.h (xmalloc, bfd_xmalloc, bfd_xmalloc_by_size_t):
	Remove decls.
	* libbfd.h: Rebuilt.

1 files changed, 83 insertions, 13 deletions

diff --git a/bfd/elf32-hppa.c b/bfd/elf32-hppa.c
index 14c520a..cb5c9e5 100644
--- a/bfd/elf32-hppa.c
+++ b/bfd/elf32-hppa.c
@@ -485,10 +485,10 @@ hppa_elf_gen_reloc_type (abfd, base_type, format, field)
   int i;
 
   final_types = (elf32_hppa_reloc_type **) bfd_alloc_by_size_t (abfd, sizeof (elf32_hppa_reloc_type *) * 2);
-  BFD_ASSERT (final_types != 0);
+  BFD_ASSERT (final_types != 0); /* FIXME */
 
   finaltype = (elf32_hppa_reloc_type *) bfd_alloc_by_size_t (abfd, sizeof (elf32_hppa_reloc_type));
-  BFD_ASSERT (finaltype != 0);
+  BFD_ASSERT (finaltype != 0);	/* FIXME */
 
   final_types[0] = finaltype;
   final_types[1] = NULL;
@@ -1090,10 +1090,10 @@ hppa_elf_gen_reloc_type (abfd, base_type, format, field)
     case R_HPPA_COMPLEX_PCREL_CALL:
     case R_HPPA_COMPLEX_ABS_CALL:
       final_types = (elf32_hppa_reloc_type **) bfd_alloc_by_size_t (abfd, sizeof (elf32_hppa_reloc_type *) * 6);
-      BFD_ASSERT (final_types != 0);
+      BFD_ASSERT (final_types != 0); /* FIXME */
 
       finaltype = (elf32_hppa_reloc_type *) bfd_alloc_by_size_t (abfd, sizeof (elf32_hppa_reloc_type) * 5);
-      BFD_ASSERT (finaltype != 0);
+      BFD_ASSERT (finaltype != 0); /* FIXME */
 
       for (i = 0; i < 5; i++)
 	final_types[i] = &finaltype[i];
@@ -1747,6 +1747,11 @@ elf_hppa_tc_symbol (abfd, symbolP, sym_idx)
     return;
 
   symextP = (symext_chainS *) bfd_alloc (abfd, sizeof (symext_chainS) * 2);
+  if (!symextP)
+    {
+      bfd_error = no_memory;
+      abort();			/* FIXME */
+    }
 
   symextP[0].entry = ELF32_HPPA_SX_WORD (HPPA_SXT_SYMNDX, sym_idx);
   symextP[0].next = &symextP[1];
@@ -1808,6 +1813,11 @@ elf_hppa_tc_make_sections (abfd, ignored)
       bfd_set_section_alignment (abfd, symextn_sec, 2);
     }
   symextn_contents = (symext_entryS *) bfd_alloc (abfd, size);
+  if (!symextn_contents)
+    {
+      bfd_error = no_memory;
+      abort();			/* FIXME */
+    }
 
   for (i = 0, symextP = symext_rootP; symextP; symextP = symextP->next, ++i)
     symextn_contents[i] = symextP->entry;
@@ -1965,7 +1975,7 @@ new_stub (abfd, stub_sec, link_info)
   else
     {
       bfd_error = no_memory;
-      bfd_perror ("new_stub");
+      abort();			/* FIXME */
     }
 
   return stub;
@@ -2031,7 +2041,7 @@ add_stub_by_name(abfd, stub_sec, sym, link_info)
       else
 	{
 	  bfd_error = no_memory;
-	  bfd_perror("add_stub_by_name");
+	  abort();		/* FIXME */
 	}
     }
 
@@ -2141,8 +2151,8 @@ type_of_mismatch (caller_bits, callee_bits, type)
 }
 
 #define CURRENT_STUB_OFFSET(entry)	\
-  ((int)(entry)->stub_desc->stub_secp \
-   - (int)(entry)->stub_desc->stub_contents - 4)
+  ((char *)(entry)->stub_desc->stub_secp \
+   - (char *)(entry)->stub_desc->stub_contents - 4)
 
 static boolean stubs_finished = false;
 
@@ -2275,13 +2285,18 @@ hppa_elf_stub_branch_reloc (stub_desc,	/* the bfd */
 	  stub_desc->stub_sec->relocation = (arelent *) realloc (stub_desc->stub_sec->relocation,
 								 size);
 	}
+      if (!stub_desc->stub_sec->relocation)
+	{
+	  bfd_error = no_memory;
+	  abort();		/* FIXME */
+	}
     }
 
   /* Fill in the details. */
   relent.address = offset;
   relent.addend = 0;
   relent.sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd, sizeof (asymbol *));
-  BFD_ASSERT (relent.sym_ptr_ptr);
+  BFD_ASSERT (relent.sym_ptr_ptr); /* FIXME */
 
   relent.sym_ptr_ptr[0] = target_sym;
   relent.howto = bfd_reloc_type_lookup (stub_desc->this_bfd, R_HPPA_PCREL_CALL_17);
@@ -2325,6 +2340,11 @@ hppa_elf_stub_reloc (stub_desc,	/* the bfd */
 	  stub_desc->stub_sec->relocation = (arelent *) realloc (stub_desc->stub_sec->relocation,
 								 size);
 	}
+      if (!stub_desc->stub_sec->relocation)
+	{
+	  bfd_error = no_memory;
+	  abort();		/* FIXME */
+	}
     }
 
   rela_hdr = &elf_section_data(stub_desc->stub_sec)->rel_hdr;
@@ -2334,7 +2354,7 @@ hppa_elf_stub_reloc (stub_desc,	/* the bfd */
   relent.address = offset;
   relent.addend = 0;
   relent.sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd, sizeof (asymbol *));
-  BFD_ASSERT (relent.sym_ptr_ptr);
+  BFD_ASSERT (relent.sym_ptr_ptr); /* FIXME */
 
   relent.sym_ptr_ptr[0] = target_sym;
   relent.howto = bfd_reloc_type_lookup (stub_desc->this_bfd, type);
@@ -2407,7 +2427,12 @@ hppa_elf_build_arg_reloc_stub (abfd, output_bfd, link_info, reloc_entry,
   if (!stub_desc->stub_contents)
     {
       stub_desc->allocated_size = STUB_BUFFER_INCR;
-      stub_desc->stub_contents = (char *) bfd_xmalloc (STUB_BUFFER_INCR);
+      stub_desc->stub_contents = (char *) malloc (STUB_BUFFER_INCR);
+      if (!stub_desc->stub_contents)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
     }
   else if ((stub_desc->allocated_size - stub_desc->real_size) < STUB_MAX_SIZE)
     {
@@ -2435,6 +2460,11 @@ hppa_elf_build_arg_reloc_stub (abfd, output_bfd, link_info, reloc_entry,
 	 change the relocation type?  */
       reloc_entry->sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd,
 							  sizeof (asymbol *));
+      if (!reloc_entry->sym_ptr_ptr)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       reloc_entry->sym_ptr_ptr[0] = stub_sym;
       if (reloc_entry->howto->type != R_HPPA_PLABEL_32
 	  && (get_opcode(insn) == BLE
@@ -2446,10 +2476,20 @@ hppa_elf_build_arg_reloc_stub (abfd, output_bfd, link_info, reloc_entry,
     {
       /* Create a new symbol to point to this stub.  */
       stub_sym = bfd_make_empty_symbol (abfd);
+      if (!stub_sym)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       stub_sym->name = bfd_zalloc (abfd, strlen (stub_sym_name) + 1);
+      if (!stub_sym->name)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       strcpy ((char *) stub_sym->name, stub_sym_name);
       stub_sym->value
-	= (int) stub_desc->stub_secp - (int) stub_desc->stub_contents;
+	= (char *) stub_desc->stub_secp - (char *) stub_desc->stub_contents;
       stub_sym->section = stub_sec;
       stub_sym->flags = BSF_LOCAL | BSF_FUNCTION;
       stub_entry = add_stub_by_name (abfd, stub_sec, stub_sym, link_info);
@@ -2459,6 +2499,11 @@ hppa_elf_build_arg_reloc_stub (abfd, output_bfd, link_info, reloc_entry,
 	 relocation to be the internal use only stub R_HPPA_STUB_CALL_17.  */
       reloc_entry->sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd,
 							  sizeof (asymbol *));
+      if (!reloc_entry->sym_ptr_ptr)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       reloc_entry->sym_ptr_ptr[0] = stub_sym;
       if (reloc_entry->howto->type != R_HPPA_PLABEL_32
 	  && (get_opcode (insn) == BLE
@@ -2929,6 +2974,11 @@ hppa_elf_build_long_branch_stub (abfd, output_bfd, link_info, reloc_entry,
 	 FIXME.  Is there a need to change the relocation type too?  */
       reloc_entry->sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd,
 							  sizeof (asymbol *));
+      if (!reloc_entry->sym_ptr_ptr)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       reloc_entry->sym_ptr_ptr[0] = stub_sym;
       reloc_entry->howto = bfd_reloc_type_lookup (abfd, R_HPPA_STUB_CALL_17);
     }
@@ -2936,10 +2986,20 @@ hppa_elf_build_long_branch_stub (abfd, output_bfd, link_info, reloc_entry,
     {
       /* We will need to allocate a new stub.  */
       stub_sym = bfd_make_empty_symbol (abfd);
+      if (!stub_sym)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       stub_sym->name = bfd_zalloc (abfd, strlen (stub_sym_name) + 1);
+      if (!stub_sym->name)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       strcpy ((char *) stub_sym->name, stub_sym_name);
       stub_sym->value
-	= (int) stub_desc->stub_secp - (int) stub_desc->stub_contents;
+	= (char *) stub_desc->stub_secp - (char *) stub_desc->stub_contents;
       stub_sym->section = stub_sec;
       stub_sym->flags = BSF_LOCAL | BSF_FUNCTION;
       stub_entry = add_stub_by_name (abfd, stub_sec, stub_sym, link_info);
@@ -2950,6 +3010,11 @@ hppa_elf_build_long_branch_stub (abfd, output_bfd, link_info, reloc_entry,
 	 FIXME.  Is there a need to change the relocation type too?  */
       reloc_entry->sym_ptr_ptr = (asymbol **) bfd_zalloc (stub_desc->this_bfd,
 							  sizeof (asymbol *));
+      if (!reloc_entry->sym_ptr_ptr)
+	{
+	  bfd_error = no_memory;
+	  return NULL;
+	}
       reloc_entry->sym_ptr_ptr[0] = stub_sym;
       reloc_entry->howto = bfd_reloc_type_lookup (abfd, R_HPPA_STUB_CALL_17);
       
@@ -3458,6 +3523,11 @@ elf32_hppa_backend_symbol_table_processing (abfd, esyms,symcnt)
   /* allocate a buffer of the appropriate size for the symextn section */
 
   symextn_hdr->contents = bfd_zalloc(abfd,symextn_hdr->sh_size);
+  if (!symextn_hdr->contents)
+    {
+      bfd_error = no_memory;
+      return false;
+    }
   symextn_hdr->size = symextn_hdr->sh_size;
 	
   /* read in the symextn section */