diff options
| author | Alan Modra <amodra@gmail.com> | 2024-03-28 19:25:42 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2024-04-02 10:32:04 +1030 |
| commit | af969b14aedcc0ae27dcefab4327ff2d153dec8b (patch) | |
| tree | 0798575242610edd85068427a07f486ee5750660 /bfd/elf32-arm.c | |
| parent | f37f8c46c2e876a524301d6916a04cf7debb6483 (diff) | |
| download | gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.zip gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.gz gdb-af969b14aedcc0ae27dcefab4327ff2d153dec8b.tar.bz2 | |
PR 30569, always call elf_backend_size_dynamic_sections
This largely mechanical patch is preparation for a followup patch.
For quite some time I've thought that it would be useful to call
elf_backend_size_dynamic_sections even when no dynamic objects are
seen by the linker. That's what this patch does, with some renaming.
There are no functional changes to the linker, just a move of the
dynobj test in bfd_elf_size_dynamic_sections to target backend
functions, replacing the asserts/aborts already there. No doubt some
of the current always_size_sections functions could be moved to
size_dynamic_sections but I haven't made that change.
Because both hooks are now always called, I have renamed
always_size_sections to early_size_sections and size_dynamic_sections
to late_size_sections. I condisdered calling late_size_sections plain
size_sections, since this is the usual target dynamic section sizing
hook, but decided that searching the sources for "size_sections" would
then hit early_size_sections and other functions.
Diffstat (limited to 'bfd/elf32-arm.c')
| -rw-r--r-- | bfd/elf32-arm.c | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c index 779c708..2dc6670 100644 --- a/bfd/elf32-arm.c +++ b/bfd/elf32-arm.c @@ -16725,8 +16725,8 @@ bfd_elf32_arm_set_byteswap_code (struct bfd_link_info *info, /* Set the sizes of the dynamic sections. */ static bool -elf32_arm_size_dynamic_sections (bfd * output_bfd ATTRIBUTE_UNUSED, - struct bfd_link_info * info) +elf32_arm_late_size_sections (bfd * output_bfd ATTRIBUTE_UNUSED, + struct bfd_link_info * info) { bfd * dynobj; asection * s; @@ -16739,7 +16739,9 @@ elf32_arm_size_dynamic_sections (bfd * output_bfd ATTRIBUTE_UNUSED, return false; dynobj = elf_hash_table (info)->dynobj; - BFD_ASSERT (dynobj != NULL); + if (dynobj == NULL) + return true; + check_use_blx (htab); if (elf_hash_table (info)->dynamic_sections_created) @@ -17111,8 +17113,7 @@ elf32_arm_size_dynamic_sections (bfd * output_bfd ATTRIBUTE_UNUSED, _TLS_MODULE_BASE_, if needed. */ static bool -elf32_arm_always_size_sections (bfd *output_bfd, - struct bfd_link_info *info) +elf32_arm_early_size_sections (bfd *output_bfd, struct bfd_link_info *info) { asection *tls_sec; struct elf32_arm_link_hash_table *htab; @@ -20312,8 +20313,8 @@ elf32_arm_backend_symbol_processing (bfd *abfd, asymbol *sym) #define elf_backend_create_dynamic_sections elf32_arm_create_dynamic_sections #define elf_backend_finish_dynamic_symbol elf32_arm_finish_dynamic_symbol #define elf_backend_finish_dynamic_sections elf32_arm_finish_dynamic_sections -#define elf_backend_size_dynamic_sections elf32_arm_size_dynamic_sections -#define elf_backend_always_size_sections elf32_arm_always_size_sections +#define elf_backend_late_size_sections elf32_arm_late_size_sections +#define elf_backend_early_size_sections elf32_arm_early_size_sections #define elf_backend_init_index_section _bfd_elf_init_2_index_sections #define elf_backend_init_file_header elf32_arm_init_file_header #define elf_backend_reloc_type_class elf32_arm_reloc_type_class |