diff options
author | Nick Clifton <nickc@redhat.com> | 2017-11-16 14:53:32 +0000 |
---|---|---|
committer | Nick Clifton <nickc@redhat.com> | 2017-11-16 14:53:32 +0000 |
commit | 80a0437873045cc08753fcac4af154e2931a99fd (patch) | |
tree | e3b95fb89146533cc423d735506ad7541741c238 /bfd/elf.c | |
parent | d8ae99a7b08e29e31446aee1e47e59943d7d9926 (diff) | |
download | gdb-80a0437873045cc08753fcac4af154e2931a99fd.zip gdb-80a0437873045cc08753fcac4af154e2931a99fd.tar.gz gdb-80a0437873045cc08753fcac4af154e2931a99fd.tar.bz2 |
Prevent illegal memory accesses when parsing incorrecctly formated core notes.
PR 22421
* elf.c (elfcore_grok_netbsd_procinfo): Check that the note is big enough.
(elfcore_grok_openbsd_procinfo): Likewise.
(elfcore_grok_nto_status): Likewise.
Diffstat (limited to 'bfd/elf.c')
-rw-r--r-- | bfd/elf.c | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -9871,6 +9871,7 @@ elfcore_grok_freebsd_psinfo (bfd *abfd, Elf_Internal_Note *note) /* Check for version 1 in pr_version. */ if (bfd_h_get_32 (abfd, (bfd_byte *) note->descdata) != 1) return FALSE; + offset = 4; /* Skip over pr_psinfosz. */ @@ -10051,6 +10052,9 @@ elfcore_netbsd_get_lwpid (Elf_Internal_Note *note, int *lwpidp) static bfd_boolean elfcore_grok_netbsd_procinfo (bfd *abfd, Elf_Internal_Note *note) { + if (note->descsz <= 0x7c + 31) + return FALSE; + /* Signal number at offset 0x08. */ elf_tdata (abfd)->core->signal = bfd_h_get_32 (abfd, (bfd_byte *) note->descdata + 0x08); @@ -10135,6 +10139,9 @@ elfcore_grok_netbsd_note (bfd *abfd, Elf_Internal_Note *note) static bfd_boolean elfcore_grok_openbsd_procinfo (bfd *abfd, Elf_Internal_Note *note) { + if (note->descsz <= 0x48 + 31) + return FALSE; + /* Signal number at offset 0x08. */ elf_tdata (abfd)->core->signal = bfd_h_get_32 (abfd, (bfd_byte *) note->descdata + 0x08); @@ -10206,6 +10213,9 @@ elfcore_grok_nto_status (bfd *abfd, Elf_Internal_Note *note, long *tid) short sig; unsigned flags; + if (note->descsz < 16) + return FALSE; + /* nto_procfs_status 'pid' field is at offset 0. */ elf_tdata (abfd)->core->pid = bfd_get_32 (abfd, (bfd_byte *) ddata); |