diff options
| author | Nick Clifton <nickc@redhat.com> | 2018-05-08 12:51:06 +0100 |
|---|---|---|
| committer | Nick Clifton <nickc@redhat.com> | 2018-05-08 12:51:06 +0100 |
| commit | 95a6d23566165208853a68d9cd3c6eedca840ec6 (patch) | |
| tree | 18cb44eee880d8c8d20b2cd2117f961603d585f1 /bfd/elf-attrs.c | |
| parent | a87a64780fde9dc8d1c3af8eda93fc1b878cd3cf (diff) | |
| download | gdb-95a6d23566165208853a68d9cd3c6eedca840ec6.zip gdb-95a6d23566165208853a68d9cd3c6eedca840ec6.tar.gz gdb-95a6d23566165208853a68d9cd3c6eedca840ec6.tar.bz2 | |
Prevent a memory exhaustion failure when running objdump on a fuzzed input file with corrupt string and attribute sections.
PR 22809
* elf.c (bfd_elf_get_str_section): Check for an excessively large
string section.
* elf-attrs.c (_bfd_elf_parse_attributes): Issue an error if the
attribute section is larger than the size of the file.
Diffstat (limited to 'bfd/elf-attrs.c')
| -rw-r--r-- | bfd/elf-attrs.c | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/bfd/elf-attrs.c b/bfd/elf-attrs.c index dfdf1a5..b353309 100644 --- a/bfd/elf-attrs.c +++ b/bfd/elf-attrs.c @@ -438,6 +438,15 @@ _bfd_elf_parse_attributes (bfd *abfd, Elf_Internal_Shdr * hdr) /* PR 17512: file: 2844a11d. */ if (hdr->sh_size == 0) return; + if (hdr->sh_size > bfd_get_file_size (abfd)) + { + /* xgettext:c-format */ + _bfd_error_handler (_("%pB: error: attribute section '%pA' too big: %#llx"), + abfd, hdr->bfd_section, (long long) hdr->sh_size); + bfd_set_error (bfd_error_invalid_operation); + return; + } + contents = (bfd_byte *) bfd_malloc (hdr->sh_size + 1); if (!contents) return; |