diff options
| author | Alan Modra <amodra@gmail.com> | 2023-06-07 14:16:06 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2023-06-07 14:16:06 +0930 |
| commit | ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02 (patch) | |
| tree | 7e5342433baeaf8305f7a9b08ab58cfc521b4dd4 /bfd/coffcode.h | |
| parent | 0a22a8f27df7d092620dfa1f0135a2dd7b44528a (diff) | |
| download | gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.zip gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.tar.gz gdb-ba75d1c55cb42114e3bb5c8abe37e5c2bd657a02.tar.bz2 | |
_bfd_free_cached_info
doc/bfdint.texi and comments in the aout and som code about this
function are just wrong, and its name is not very apt. Better would
be _bfd_mostly_destroy, and we certainly should not be saying anything
about the possibility of later recreating anything lost by this
function. What's more, if _bfd_free_cached_info is called when
creating an archive map to reduce memory usage by throwing away
symbols, the target _close_and_cleanup function won't have access to
tdata or section bfd_user_data to tidy memory. This means most of the
target _close_and_cleanup function won't do anything, and therefore
sometimes will result in memory leaks.
This patch fixes the documentation problems and moves most of the
target _close_and_cleanup code to target _bfd_free_cached_info.
Another notable change is that bfd_generic_bfd_free_cached_info is now
defined as _bfd_free_cached_info rather than _bfd_bool_bfd_true,
ie. the default now frees objalloc memory.
Diffstat (limited to 'bfd/coffcode.h')
| -rw-r--r-- | bfd/coffcode.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bfd/coffcode.h b/bfd/coffcode.h index 4756271..6272025 100644 --- a/bfd/coffcode.h +++ b/bfd/coffcode.h @@ -5866,11 +5866,11 @@ static const bfd_coff_backend_data bigobj_swap_table = #endif /* COFF_WITH_PE_BIGOBJ */ #ifndef coff_close_and_cleanup -#define coff_close_and_cleanup _bfd_coff_close_and_cleanup +#define coff_close_and_cleanup _bfd_generic_close_and_cleanup #endif #ifndef coff_bfd_free_cached_info -#define coff_bfd_free_cached_info _bfd_generic_bfd_free_cached_info +#define coff_bfd_free_cached_info _bfd_coff_free_cached_info #endif #ifndef coff_get_section_contents |