diff options
| author | Tom Tromey <tom@tromey.com> | 2023-07-30 10:26:07 -0600 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2023-08-03 07:39:15 -0600 |
| commit | f559e52a8e79585e0b13156e949a7fd46060a714 (patch) | |
| tree | 9ccc07385f1c6e11b233b4b711f8cbd37ddf8d45 /bfd/coff-loongarch64.c | |
| parent | f8c4789c7f4efa3726ec39256b9860e4df9f8177 (diff) | |
| download | gdb-f559e52a8e79585e0b13156e949a7fd46060a714.zip gdb-f559e52a8e79585e0b13156e949a7fd46060a714.tar.gz gdb-f559e52a8e79585e0b13156e949a7fd46060a714.tar.bz2 | |
Remove PEI_HEADERS define
I noticed a few files double-included libcoff.h, and digging deeper I
found that the PEI_HEADERS define is a sort of external include guard.
This patch adds include guards to the few files in include/coff that
were missing one, and then removes the PEI_HEADERS workaround and the
redundant includes.
I didn't see anything in these files that indicated that
double-inclusion would be useful, so it seems to me that this approach
is ok.
Tested by rebuilding with --enable-targets=all.
2023-08-02 Tom Tromey <tromey@adacore.com>
* pei-x86_64.c (PEI_HEADERS): Do not define.
* pei-loongarch64.c (PEI_HEADERS): Do not define.
* pei-aarch64.c (PEI_HEADERS): Do not define.
* pe-x86_64.c (PEI_HEADERS): Do not define.
* pe-aarch64.c (PEI_HEADERS): Do not define.
* libpei.h (_LIBPEI_H): Add include guard.
* coff-x86_64.c (PEI_HEADERS): Do not check.
* coff-loongarch64.c (PEI_HEADERS): Do not check.
* coff-aarch64.c (PEI_HEADERS): Do not check.
include/ChangeLog
2023-08-02 Tom Tromey <tromey@adacore.com>
* coff/x86_64.h (COFF_X86_64_H): Add include guard.
* coff/loongarch64.h (COFF_LOONGARCH64_H): Add include guard.
* coff/aarch64.h (COFF_AARCH64_H): Add include guard.
Diffstat (limited to 'bfd/coff-loongarch64.c')
| -rw-r--r-- | bfd/coff-loongarch64.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/bfd/coff-loongarch64.c b/bfd/coff-loongarch64.c index 9136e06..8ae3f84 100644 --- a/bfd/coff-loongarch64.c +++ b/bfd/coff-loongarch64.c @@ -23,10 +23,6 @@ #define COFF_WITH_peLoongArch64 #endif -/* Note we have to make sure not to include headers twice. - Not all headers are wrapped in #ifdef guards, so we define - PEI_HEADERS to prevent double including here. */ -#ifndef PEI_HEADERS #include "sysdep.h" #include "bfd.h" #include "libbfd.h" @@ -35,9 +31,6 @@ #include "coff/pe.h" #include "libcoff.h" #include "libiberty.h" -#endif - -#include "libcoff.h" /* The page size is a guess based on ELF. */ |