Touches most files in bfd/, so likely will be blamed for everything..

o  bfd_read and bfd_write lose an unnecessary param and become
   bfd_bread and bfd_bwrite.

o  bfd_*alloc now all take a bfd_size_type arg, and will error if
   size_t is too small.  eg. 32 bit host, 64 bit bfd, verrry big files
   or bugs in linker scripts etc.

o  file_ptr becomes a bfd_signed_vma.  Besides matching sizes with
   various other types involved in handling sections, this should make
   it easier for bfd to support a 64 bit off_t on 32 bit hosts that
   provide it.

o  I've made the H_GET_* and H_PUT_* macros (which invoke bfd_h_{get,put}_*)
   generally available.  They now cast their args to bfd_vma and
   bfd_byte * as appropriate, which removes a swag of casts from the
   source.

o  Bug fixes to bfd_get8, aix386_core_vec, elf32_h8_relax_section, and
   aout-encap.c.

o  Zillions of formatting and -Wconversion fixes.

1 files changed, 10 insertions, 13 deletions

diff --git a/bfd/coff-ia64.c b/bfd/coff-ia64.c
index 8452d96..76d1bf6 100644
--- a/bfd/coff-ia64.c
+++ b/bfd/coff-ia64.c
@@ -77,9 +77,9 @@ ia64coff_object_p (abfd)
     struct external_PEI_IMAGE_hdr image_hdr;
     file_ptr offset;
 
-    if (bfd_seek (abfd, 0x00, SEEK_SET) != 0
-	|| bfd_read (&dos_hdr, 1, sizeof (dos_hdr), abfd)
-	   != sizeof (dos_hdr))
+    if (bfd_seek (abfd, (file_ptr) 0, SEEK_SET) != 0
+	|| (bfd_bread (&dos_hdr, (bfd_size_type) sizeof (dos_hdr), abfd)
+	    != sizeof (dos_hdr)))
       {
 	if (bfd_get_error () != bfd_error_system_call)
 	  bfd_set_error (bfd_error_wrong_format);
@@ -96,23 +96,23 @@ ia64coff_object_p (abfd)
        this routine can only be called correctly for a PEI file, check
        the e_magic number here, and, if it doesn't match, clobber the
        f_magic number so that we don't get a false match.  */
-    if (bfd_h_get_16 (abfd, (bfd_byte *) dos_hdr.e_magic) != DOSMAGIC)
+    if (H_GET_16 (abfd, dos_hdr.e_magic) != DOSMAGIC)
       {
 	bfd_set_error (bfd_error_wrong_format);
 	return NULL;
       }
 
-    offset = bfd_h_get_32 (abfd, (bfd_byte *) dos_hdr.e_lfanew);
-    if (bfd_seek (abfd, (file_ptr) offset, SEEK_SET) != 0
-	|| bfd_read (&image_hdr, 1, sizeof (image_hdr), abfd)
-	   != sizeof (image_hdr))
+    offset = H_GET_32 (abfd, dos_hdr.e_lfanew);
+    if (bfd_seek (abfd, offset, SEEK_SET) != 0
+	|| (bfd_bread (&image_hdr, (bfd_size_type) sizeof (image_hdr), abfd)
+	    != sizeof (image_hdr)))
       {
 	if (bfd_get_error () != bfd_error_system_call)
 	  bfd_set_error (bfd_error_wrong_format);
 	return NULL;
       }
 
-    if (bfd_h_get_32 (abfd, (bfd_byte *) image_hdr.nt_signature)
+    if (H_GET_32 (abfd, image_hdr.nt_signature)
 	!= 0x4550)
       {
 	bfd_set_error (bfd_error_wrong_format);
@@ -122,10 +122,7 @@ ia64coff_object_p (abfd)
     /* Here is the hack.  coff_object_p wants to read filhsz bytes to
        pick up the COFF header for PE, see "struct external_PEI_filehdr"
        in include/coff/pe.h.  We adjust so that that will work. */
-    if (bfd_seek (abfd,
-		  (file_ptr) (offset - sizeof (dos_hdr)),
-		  SEEK_SET)
-	!= 0)
+    if (bfd_seek (abfd, offset - sizeof (dos_hdr), SEEK_SET) != 0)
       {
 	if (bfd_get_error () != bfd_error_system_call)
 	  bfd_set_error (bfd_error_wrong_format);