diff options
| author | Alan Modra <amodra@gmail.com> | 2015-01-29 11:09:55 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2015-01-29 13:13:02 +1030 |
| commit | b86ac8e3a5a3117696b1760003b8e09ed13f1de9 (patch) | |
| tree | 62ef24abc3d0ef13113729ea6f1ae626e556e4af /bfd/ChangeLog | |
| parent | 912ae7dd0fa4658133d4fb77954a57c8548c37d6 (diff) | |
| download | gdb-b86ac8e3a5a3117696b1760003b8e09ed13f1de9.zip gdb-b86ac8e3a5a3117696b1760003b8e09ed13f1de9.tar.gz gdb-b86ac8e3a5a3117696b1760003b8e09ed13f1de9.tar.bz2 | |
Correct PowerPC64 local-dynamic TLS linker optimization
The linker hardcoded r3 into a local-dynamic to local-exec TLS
optimization sequence. This is normally the case since r3 is required
as a parameter to (the optimized out) __tls_get_addr call. However,
it is possible for a compiler, LLVM in this case, to set up the
parameter value in another register then copy it to r3 before the
call.
When fixing this problem, I noticed that ppc32 had another bug when
optimizing away one of the TLS insns to a nop.
The patch also tidies a mask used by global-dynamic to initial-exec
TLS optimization, to just select the fields needed. Leaving the
offset in the instruction wasn't a bug since it will be overwritten
anyway.
bfd/
* elf64-ppc.c (ppc64_elf_relocate_section): Correct GOT_TLSLD
optimization. Tidy mask for GOT_TLSGD optimization.
* elf32-ppc.c (ppc_elf_relocate_section): Likewise. Correct
location of nop zapping high insn too.
ld/testsuite/
* ld-powerpc/tlsld.d, * ld-powerpc/tlsld.s: New test.
* ld-powerpc/tlsld32.d, * ld-powerpc/tlsld32.s: New test.
* ld-powerpc/powerpc.exp: Run them. Move tocvar and tocnovar.
Diffstat (limited to 'bfd/ChangeLog')
| -rw-r--r-- | bfd/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index f5a50fa..464400f 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2015-01-29 Alan Modra <amodra@gmail.com> + + * elf64-ppc.c (ppc64_elf_relocate_section): Correct GOT_TLSLD + optimization. Tidy mask for GOT_TLSGD optimization. + * elf32-ppc.c (ppc_elf_relocate_section): Likewise. Correct + location of nop zapping high insn too. + 2015-01-28 Alan Modra <amodra@gmail.com> * elf64-ppc.h (struct ppc64_elf_params): Add "object_in_toc". |