aboutsummaryrefslogtreecommitdiff
path: root/ar-lib
diff options
context:
space:
mode:
authorBruno Larsen <blarsen@redhat.com>2021-10-29 17:56:28 -0300
committerBruno Larsen <blarsen@redhat.com>2021-11-25 09:56:03 -0300
commita41ad3474ceacba39e11c7478154c0e553784a01 (patch)
treedb9de693ebbb1b1596b4df4a12d3f229f4d250b9 /ar-lib
parent423e91d347cf6050ac17c7098cad6cbc15e5e50f (diff)
downloadgdb-a41ad3474ceacba39e11c7478154c0e553784a01.zip
gdb-a41ad3474ceacba39e11c7478154c0e553784a01.tar.gz
gdb-a41ad3474ceacba39e11c7478154c0e553784a01.tar.bz2
PR gdb/28480: Improve ambiguous member detection
Basic ambiguity detection assumes that when 2 fields with the same name have the same byte offset, it must be an unambiguous request. This is not always correct. Consider the following code: class empty { }; class A { public: [[no_unique_address]] empty e; }; class B { public: int e; }; class C: public A, public B { }; if we tried to use c.e in code, the compiler would warn of an ambiguity, however, since A::e does not demand an unique address, it gets the same address (and thus byte offset) of the members, making A::e and B::e have the same address. however, "print c.e" would fail to report the ambiguity, and would instead print it as an empty class (first path found). The new code solves this by checking for other found_fields that have different m_struct_path.back() (final class that the member was found in), despite having the same byte offset. The testcase gdb.cp/ambiguous.exp was also changed to test for this behavior.
Diffstat (limited to 'ar-lib')
0 files changed, 0 insertions, 0 deletions