diff options
| author | Nick Alcock <nick.alcock@oracle.com> | 2019-07-13 19:47:11 +0100 |
|---|---|---|
| committer | Nick Alcock <nick.alcock@oracle.com> | 2019-09-23 14:12:54 +0100 |
| commit | 417ed2883b183a7f9b0c78759736edb085a44e1b (patch) | |
| tree | b93c378b21aa1dcef576d1779e8263cbe5bd7004 | |
| parent | 42859bb4a13a51167fd7a9bab9ae88b9438611f3 (diff) | |
| download | gdb-417ed2883b183a7f9b0c78759736edb085a44e1b.zip gdb-417ed2883b183a7f9b0c78759736edb085a44e1b.tar.gz gdb-417ed2883b183a7f9b0c78759736edb085a44e1b.tar.bz2 | |
binutils: readelf: when dumping CTF, load strtab and symtab automatically
We were only loading them when explicitly requested, which leads to
strings that point off into empty space (into the non-loaded "external"
ELF string table). Avoid this unfortunate consequence by loading the
strtab and symtab by default, unless a blank name is given.
binutils/
* readelf.c (dump_ctf_symtab_name): Give default value.
(dump_ctf_strtab_name): Likewise.
(dump_section_as_ctf): Allow for the null string.
| -rw-r--r-- | binutils/ChangeLog | 6 | ||||
| -rw-r--r-- | binutils/doc/binutils.texi | 3 | ||||
| -rw-r--r-- | binutils/readelf.c | 10 |
3 files changed, 16 insertions, 3 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog index f5d08fb..c15d783 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,9 @@ +2019-07-13 Nick Alcock <nick.alcock@oracle.com> + + * readelf.c (dump_ctf_symtab_name): Give default value. + (dump_ctf_strtab_name): Likewise. + (dump_section_as_ctf): Allow for the null string. + 2019-07-08 Nick Alcock <nick.alcock@oracle.com> * objdump.c (dump_ctf_archive_member): Dump the CTF header. diff --git a/binutils/doc/binutils.texi b/binutils/doc/binutils.texi index bb37cb0..a548180 100644 --- a/binutils/doc/binutils.texi +++ b/binutils/doc/binutils.texi @@ -4850,7 +4850,8 @@ command to @command{ar}, but without using the BFD library. @xref{ar}. @item --ctf-symbols=@var{section} @item --ctf-strings=@var{section} Specify the name of another section from which the CTF file can inherit -strings and symbols. +strings and symbols. By default, the @code{.symtab} and its linked +string table are used. If either of @option{--ctf-symbols} or @option{--ctf-strings} is specified, the other must be specified as well. diff --git a/binutils/readelf.c b/binutils/readelf.c index 40957b0..4597068 100644 --- a/binutils/readelf.c +++ b/binutils/readelf.c @@ -13944,7 +13944,13 @@ dump_section_as_ctf (Elf_Internal_Shdr * section, Filedata * filedata) data = get_section_contents (section, filedata); ctfsect.cts_data = data; - if (dump_ctf_symtab_name) + if (!dump_ctf_symtab_name) + dump_ctf_symtab_name = strdup (".symtab"); + + if (!dump_ctf_strtab_name) + dump_ctf_strtab_name = strdup (".strtab"); + + if (dump_ctf_symtab_name && dump_ctf_symtab_name[0] != 0) { if ((symtab_sec = find_section (filedata, dump_ctf_symtab_name)) == NULL) { @@ -13959,7 +13965,7 @@ dump_section_as_ctf (Elf_Internal_Shdr * section, Filedata * filedata) symsectp = shdr_to_ctf_sect (&symsect, symtab_sec, filedata); symsect.cts_data = symdata; } - if (dump_ctf_strtab_name) + if (dump_ctf_strtab_name && dump_ctf_symtab_name[0] != 0) { if ((strtab_sec = find_section (filedata, dump_ctf_strtab_name)) == NULL) { |