aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2021-03-08 07:27:57 -0700
committerTom Tromey <tom@tromey.com>2021-03-08 07:28:27 -0700
commite4407a202d31a6873ea240b13125bf1ae8d20401 (patch)
tree2e9e5c7209830771fda18563ea9a082084662e20
parent9db6b6ddbd3a384d3a80bfee3e3a5c5a40fd43d0 (diff)
downloadgdb-e4407a202d31a6873ea240b13125bf1ae8d20401.zip
gdb-e4407a202d31a6873ea240b13125bf1ae8d20401.tar.gz
gdb-e4407a202d31a6873ea240b13125bf1ae8d20401.tar.bz2
Implement Rust field operations
This implements the field operations STRUCTOP_STRUCT and STRUCTOP_ANONYMOUS, for Rust. gdb/ChangeLog 2021-03-08 Tom Tromey <tom@tromey.com> * rust-lang.c (eval_op_rust_struct_anon, eval_op_rust_structop): No longer static. * rust-exp.h (class rust_struct_anon): New. (class rust_structop): New.
-rw-r--r--gdb/ChangeLog7
-rw-r--r--gdb/rust-exp.h53
-rw-r--r--gdb/rust-lang.c4
3 files changed, 62 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 764c432..69a514c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,12 @@
2021-03-08 Tom Tromey <tom@tromey.com>
+ * rust-lang.c (eval_op_rust_struct_anon, eval_op_rust_structop):
+ No longer static.
+ * rust-exp.h (class rust_struct_anon): New.
+ (class rust_structop): New.
+
+2021-03-08 Tom Tromey <tom@tromey.com>
+
* rust-lang.c (rust_range): No longer static.
* rust-exp.h (class rust_range_operation): New.
diff --git a/gdb/rust-exp.h b/gdb/rust-exp.h
index 263d41a..19e945c 100644
--- a/gdb/rust-exp.h
+++ b/gdb/rust-exp.h
@@ -46,6 +46,16 @@ extern struct value *rust_range (struct type *expect_type,
struct expression *exp,
enum noside noside, enum range_flag kind,
struct value *low, struct value *high);
+extern struct value *eval_op_rust_struct_anon (struct type *expect_type,
+ struct expression *exp,
+ enum noside noside,
+ int field_number,
+ struct value *lhs);
+extern struct value *eval_op_rust_structop (struct type *expect_type,
+ struct expression *exp,
+ enum noside noside,
+ struct value *lhs,
+ const char *field_name);
namespace expr
{
@@ -154,6 +164,49 @@ public:
{ return OP_RANGE; }
};
+/* Tuple field reference (using an integer). */
+class rust_struct_anon
+ : public tuple_holding_operation<int, operation_up>
+{
+public:
+
+ using tuple_holding_operation::tuple_holding_operation;
+
+ value *evaluate (struct type *expect_type,
+ struct expression *exp,
+ enum noside noside) override
+ {
+ value *lhs = std::get<1> (m_storage)->evaluate (nullptr, exp, noside);
+ return eval_op_rust_struct_anon (expect_type, exp, noside,
+ std::get<0> (m_storage), lhs);
+
+ }
+
+ enum exp_opcode opcode () const override
+ { return STRUCTOP_ANONYMOUS; }
+};
+
+/* Structure (or union or enum) field reference. */
+class rust_structop
+ : public structop_base_operation
+{
+public:
+
+ using structop_base_operation::structop_base_operation;
+
+ value *evaluate (struct type *expect_type,
+ struct expression *exp,
+ enum noside noside) override
+ {
+ value *lhs = std::get<0> (m_storage)->evaluate (nullptr, exp, noside);
+ return eval_op_rust_structop (expect_type, exp, noside, lhs,
+ std::get<1> (m_storage).c_str ());
+ }
+
+ enum exp_opcode opcode () const override
+ { return STRUCTOP_STRUCT; }
+};
+
} /* namespace expr */
#endif /* RUST_EXP_H */
diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c
index 46eb03e..1373de9 100644
--- a/gdb/rust-lang.c
+++ b/gdb/rust-lang.c
@@ -1388,7 +1388,7 @@ eval_op_rust_array (struct type *expect_type, struct expression *exp,
/* A helper function for STRUCTOP_ANONYMOUS. */
-static struct value *
+struct value *
eval_op_rust_struct_anon (struct type *expect_type, struct expression *exp,
enum noside noside,
int field_number, struct value *lhs)
@@ -1455,7 +1455,7 @@ tuple structs, and tuple-like enum variants"));
/* A helper function for STRUCTOP_STRUCT. */
-static struct value *
+struct value *
eval_op_rust_structop (struct type *expect_type, struct expression *exp,
enum noside noside,
struct value *lhs, const char *field_name)