diff options
| author | Tom Tromey <tom@tromey.com> | 2021-10-29 17:04:09 -0600 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2021-10-31 11:35:28 -0600 |
| commit | 6e195444fbde94477ffbaecd37f0b2d9c3f4ed3f (patch) | |
| tree | 070acaf8d2efb77b8f2a4a20731b9dcca4f21574 | |
| parent | 2a8f1f474469bd1a35435deaf5fb0a2ce038071d (diff) | |
| download | gdb-6e195444fbde94477ffbaecd37f0b2d9c3f4ed3f.zip gdb-6e195444fbde94477ffbaecd37f0b2d9c3f4ed3f.tar.gz gdb-6e195444fbde94477ffbaecd37f0b2d9c3f4ed3f.tar.bz2 | |
Fix latent bug in DWARF test case
On my branch that replaces the DWARF psymtab reader,
dw2-stack-boundary.exp started failing. However, when I look at the
output in gdb.log, it is correct:
file /home/tromey/gdb/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-stack-boundary/dw2-stack-boundary
Reading symbols from /home/tromey/gdb/build/gdb/testsuite/outputs/gdb.dwarf2/dw2-stack-boundary/dw2-stack-boundary...
During symbol reading: location description stack overflow
During symbol reading: location description stack underflow
What happens to cause the failure is that the two branches in
gdb_test_multiple appear in this order:
-re "\r\nDuring symbol reading: location description stack underflow" {
[...]
-re "\r\nDuring symbol reading: location description stack overflow" {
The first one will match the above, without causing the second one to
ever match -- leading to a spurious failure.
Anchoring the regexps seems to fix the problem, and works for the
current gdb as well.
| -rw-r--r-- | gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp b/gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp index 8b81b5b..054d0c6 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp @@ -44,11 +44,11 @@ gdb_test_multiple "file $binfile" "file command" { -re "\r\nReading symbols from \[^\r\n\]*\\.\\.\\." { exp_continue } - -re "\r\nDuring symbol reading: location description stack underflow" { + -re "^\r\nDuring symbol reading: location description stack underflow" { set w1 1 exp_continue } - -re "\r\nDuring symbol reading: location description stack overflow" { + -re "^\r\nDuring symbol reading: location description stack overflow" { set w2 1 exp_continue } |