diff options
| author | Lancelot SIX <lancelot.six@amd.com> | 2022-11-04 15:36:21 +0000 |
|---|---|---|
| committer | Lancelot SIX <lancelot.six@amd.com> | 2022-11-04 16:18:27 +0000 |
| commit | 36354a49b603408daf579d71a9684a0fc37311a7 (patch) | |
| tree | 63bbe6277c65af340178d4e3ff7c3fc9b236f6db | |
| parent | 45830439cef3c827ae5ddb3915a1edcf1206dc77 (diff) | |
| download | gdb-36354a49b603408daf579d71a9684a0fc37311a7.zip gdb-36354a49b603408daf579d71a9684a0fc37311a7.tar.gz gdb-36354a49b603408daf579d71a9684a0fc37311a7.tar.bz2 | |
[testsuite] gdb.base/dlmopen: Fix test name and use gdb_attach
One test name in gdb.base/dlmopen.exp changes from run to run
since it includes a process id:
PASS: gdb.base/dlmopen.exp: attach 3442682
This is not convenient do diff gdb.sum files to compare test runs.
Fix by using gdb_attach helper function to handle attaching to the
process as it produce a constant test name.
While at it also check gdb_attach's return value to only run the
rest of the test if the attach was successful.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
| -rw-r--r-- | gdb/testsuite/gdb.base/dlmopen.exp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.base/dlmopen.exp b/gdb/testsuite/gdb.base/dlmopen.exp index a80db75..31f7400 100644 --- a/gdb/testsuite/gdb.base/dlmopen.exp +++ b/gdb/testsuite/gdb.base/dlmopen.exp @@ -159,7 +159,9 @@ set test_spawn_id [spawn_wait_for_attach $binfile] set testpid [spawn_id_get_pid $test_spawn_id] # Attach. -gdb_test "attach $testpid" "Attaching to program.*, process $testpid.*" +if { ![gdb_attach $testpid] } { + return +} with_test_prefix "attach" { # Remove the pause. We no longer need it. |