diff options
| author | Joel Brobecker <brobecker@adacore.com> | 2013-12-19 15:48:39 +0400 |
|---|---|---|
| committer | Joel Brobecker <brobecker@adacore.com> | 2014-01-07 08:17:38 +0400 |
| commit | 760a2db02f0d160c7990c52903bd9aaa796bd815 (patch) | |
| tree | a852bf04a359fa689357e89fe6dcab3a77e8312b | |
| parent | 3a92c861bbbd25cb894942f79d0c6f7f8bbd1de6 (diff) | |
| download | gdb-760a2db02f0d160c7990c52903bd9aaa796bd815.zip gdb-760a2db02f0d160c7990c52903bd9aaa796bd815.tar.gz gdb-760a2db02f0d160c7990c52903bd9aaa796bd815.tar.bz2 | |
Remove call to gdb_flush at end of ada_val_print_1
I am not sure why this function was called in the first place, but
it disrupts the printing flow when in GDB/MI mode, ending the current
console stream output, and starting a new one. It's not clear whether,
with the code as currently written, the problem is actually visible
or only latent. But, it becomes visible when we replace one of the
"return" statements in the "switch" block just above by a "break"
statement (this is something I'd like to do, and what made me realize
the problem). With the gdb_flush call (after having replaced the
"return" statement as explained above), we get:
% gdb -q -i=mi ada_prg
(gdb)
print 1
&"print 1\n"
!! -> ~"$1 = 1"
!! -> ~"\n"
^done
With the gdb_flush call removed, we now get the entire output into
a single stream.
(gdb)
print 1
&"print 1\n"
~"$1 = 1"
~"\n"
^done
gdb/ChangeLog:
* ada-valprint.c (ada_val_print_1): Remove call to gdb_flush.
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/ada-valprint.c | 1 |
2 files changed, 4 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ee0df63..f8820a5 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,9 @@ 2014-01-07 Joel Brobecker <brobecker@adacore.com> + * ada-valprint.c (ada_val_print_1): Remove call to gdb_flush. + +2014-01-07 Joel Brobecker <brobecker@adacore.com> + * ada-valprint.c (ada_val_print_1): Replace calls to ada_val_print_1 by calls to val_print. diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c index ff0fa66..9c60a79 100644 --- a/gdb/ada-valprint.c +++ b/gdb/ada-valprint.c @@ -1044,7 +1044,6 @@ ada_val_print_1 (struct type *type, const gdb_byte *valaddr, break; } - gdb_flush (stream); } /* See val_print for a description of the various parameters of this |