diff options
| author | Tom Tromey <tromey@adacore.com> | 2022-02-28 10:53:13 -0700 |
|---|---|---|
| committer | Tom Tromey <tromey@adacore.com> | 2022-02-28 10:53:13 -0700 |
| commit | 29928b8e3b79e14abb11cfa78daec447158b79d4 (patch) | |
| tree | 9fa232a699ac985238981721159626cc1614982b | |
| parent | c9f66f0005000492739dd063ea2949045bf70bc6 (diff) | |
| download | gdb-29928b8e3b79e14abb11cfa78daec447158b79d4.zip gdb-29928b8e3b79e14abb11cfa78daec447158b79d4.tar.gz gdb-29928b8e3b79e14abb11cfa78daec447158b79d4.tar.bz2 | |
Fix maybe-uninitialized warning in py-infthread.c
I got this warning from py-infthread.c using the Fedora 34 system GCC:
../../binutils-gdb/gdb/python/py-infthread.c:102:30: warning: ‘extra_info’ may be used uninitialized in this function [-Wmaybe-uninitialized]
I think this happens because GDB_PY_HANDLE_EXCEPTION expands to an
'if' whose condition is always true -- but GCC can't know this. This
patch avoids the warning by adding a harmless initialization.
| -rw-r--r-- | gdb/python/py-infthread.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/python/py-infthread.c b/gdb/python/py-infthread.c index 66c3efd..c94d5b0 100644 --- a/gdb/python/py-infthread.c +++ b/gdb/python/py-infthread.c @@ -87,7 +87,9 @@ thpy_get_details (PyObject *self, void *ignore) THPY_REQUIRE_VALID (thread_obj); - const char *extra_info; + /* GCC can't tell that extra_info will always be assigned after the + 'catch', so initialize it. */ + const char *extra_info = nullptr; try { extra_info = target_extra_thread_info (thread_obj->thread); |