aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2017-10-12 19:16:47 +0100
committerPedro Alves <palves@redhat.com>2017-10-12 19:16:54 +0100
commit30440677f3d0cdd2085bea40496774ffa24f6bb1 (patch)
tree06e8eb42e9c20482863a6b91dd844f4df250ee79
parent4e04f0450f83d8d0ad08579b5e6c8b4e8a8e693f (diff)
downloadgdb-30440677f3d0cdd2085bea40496774ffa24f6bb1.zip
gdb-30440677f3d0cdd2085bea40496774ffa24f6bb1.tar.gz
gdb-30440677f3d0cdd2085bea40496774ffa24f6bb1.tar.bz2
Tighten remote check in gdb.base/argv0-symlink.exp
Check for gdbserver instead of dejagnu remote. Unlike what the comment says, the test actually fails with target remote + gdbserver (it does pass with extended-remote). The result is: FAIL -> KFAIL with --target_board=native-gdbserver KPASS -> PASS with --target_board=native-extended-gdbserver gdb/testsuite/ChangeLog: 2017-10-12 Pedro Alves <palves@redhat.com> Simon Marchi <simon.marchi@polymtl.ca> * gdb.base/argv0-symlink.exp: kfail on remote gdbserver, instead of on dejagnu remote boards.
-rw-r--r--gdb/testsuite/ChangeLog6
-rw-r--r--gdb/testsuite/gdb.base/argv0-symlink.exp5
2 files changed, 9 insertions, 2 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 0fa3afb..e6a4281 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,4 +1,10 @@
2017-10-12 Pedro Alves <palves@redhat.com>
+ Simon Marchi <simon.marchi@polymtl.ca>
+
+ * gdb.base/argv0-symlink.exp: kfail on remote gdbserver,
+ instead of on dejagnu remote boards.
+
+2017-10-12 Pedro Alves <palves@redhat.com>
Simon Marchi <simon.marchi@polymtl.ca>
* gdb.base/inferior-died.exp: Remove is_remote and isnative
diff --git a/gdb/testsuite/gdb.base/argv0-symlink.exp b/gdb/testsuite/gdb.base/argv0-symlink.exp
index a1248ed..efac9e0 100644
--- a/gdb/testsuite/gdb.base/argv0-symlink.exp
+++ b/gdb/testsuite/gdb.base/argv0-symlink.exp
@@ -80,8 +80,9 @@ gdb_test_no_output "set print repeats 10000"
gdb_test_no_output "set print elements 10000"
if { $has_argv0 } {
- # gdbserver does not have this issue.
- if ![is_remote target] {
+ # gdbserver in extended-remote mode does not have this issue.
+ # Plain remote does, however.
+ if {[target_info gdb_protocol] != "extended-remote" || ![target_is_gdbserver]} {
setup_kfail "*-*-*" gdb/15934
}
gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test