aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPedro Alves <palves@redhat.com>2017-10-12 19:54:34 +0100
committerPedro Alves <palves@redhat.com>2017-10-12 19:54:57 +0100
commite48ef82dd2fc85560d14a45a632c82eaaadca7ce (patch)
treea018fe5cbfacba183238257370e1a39ea624ea3b
parent8d7aea574a8ab3a235088866860df75b542ae4a3 (diff)
downloadgdb-e48ef82dd2fc85560d14a45a632c82eaaadca7ce.zip
gdb-e48ef82dd2fc85560d14a45a632c82eaaadca7ce.tar.gz
gdb-e48ef82dd2fc85560d14a45a632c82eaaadca7ce.tar.bz2
checkpoint.exp: Check for non-"target native" instead of isnative/is_remote
This gets rid of a number of FAILs with --target_board=native-extended-gdbserver. The fact that checkpointing does not work has nothing to do with dejagnu's native and remote concepts. It only works with native Linux targets because the implementation is currently baked with linux-nat.c. gdb/testsuite/ChangeLog: 2017-10-12 Pedro Alves <palves@redhat.com> Simon Marchi <simon.marchi@polymtl.ca> * gdb.base/checkpoint.exp: Don't check is_remote or isnative. Instead skip if there's any gdb_protocol set.
-rw-r--r--gdb/testsuite/ChangeLog6
-rw-r--r--gdb/testsuite/gdb.base/checkpoint.exp10
2 files changed, 12 insertions, 4 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 8ecdc50..4876914 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2017-10-12 Pedro Alves <palves@redhat.com>
+ Simon Marchi <simon.marchi@polymtl.ca>
+
+ * gdb.base/checkpoint.exp: Don't check is_remote or isnative.
+ Instead skip if there's any gdb_protocol set.
+
2017-10-12 Simon Marchi <simon.marchi@polymtl.ca>
Pedro Alves <palves@redhat.com>
diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp
index 677c389..b93c5f4 100644
--- a/gdb/testsuite/gdb.base/checkpoint.exp
+++ b/gdb/testsuite/gdb.base/checkpoint.exp
@@ -13,10 +13,6 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>. */
-if { [is_remote target] || ![isnative] } then {
- continue
-}
-
# Until "set follow-fork-mode" and "catch fork" are implemented on
# other targets...
#
@@ -24,6 +20,12 @@ if {![istarget "*-*-linux*"]} then {
continue
}
+# Checkpoint support is currently implemented in the Linux native
+# target, so only works with "target native".
+if { [target_info gdb_protocol] != "" } {
+ continue
+}
+
# Must name the source file explicitly, otherwise when driven by
# checkpoints-ns.exp, we'd try compiling checkpoints-ns.c, which
# doesn't exist.