diff options
| author | Andrew Burgess <aburgess@redhat.com> | 2022-09-22 19:10:52 +0100 |
|---|---|---|
| committer | Andrew Burgess <aburgess@redhat.com> | 2022-12-14 13:57:22 +0000 |
| commit | 9678f8fe975c213c94735221dcb438395e4de9e1 (patch) | |
| tree | cb3bbbd084837f973f00217d4ca2dc6a12421925 | |
| parent | 91e3d1d1a5462e49bbf70e0ff2fa3bf3a6a80503 (diff) | |
| download | gdb-9678f8fe975c213c94735221dcb438395e4de9e1.zip gdb-9678f8fe975c213c94735221dcb438395e4de9e1.tar.gz gdb-9678f8fe975c213c94735221dcb438395e4de9e1.tar.bz2 | |
gdb: remove decref_target
The decref_target function is not really needed. Calling
target_ops::decref will just redirect to decref_target anyway, so why
not just rename decref_target to target_ops::decref?
That's what this commit does.
It's not exactly renaming to target_ops::decref, because the decref
functionality is handled by a policy class, so the new name is now
target_ops_ref_policy::decref.
There should be no user visible change after this commit.
| -rw-r--r-- | gdb/target.c | 2 | ||||
| -rw-r--r-- | gdb/target.h | 10 |
2 files changed, 4 insertions, 8 deletions
diff --git a/gdb/target.c b/gdb/target.c index b3fd234..417d384 100644 --- a/gdb/target.c +++ b/gdb/target.c @@ -1166,7 +1166,7 @@ to_execution_direction must be implemented for reverse async"); /* See target.h. */ void -decref_target (target_ops *t) +target_ops_ref_policy::decref (target_ops *t) { t->decref (); if (t->refcount () == 0) diff --git a/gdb/target.h b/gdb/target.h index b9888f8..68446a39 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -1337,9 +1337,6 @@ struct target_ops_deleter /* A unique pointer for target_ops. */ typedef std::unique_ptr<target_ops, target_ops_deleter> target_ops_up; -/* Decref a target and close if, if there are no references left. */ -extern void decref_target (target_ops *t); - /* A policy class to interface gdb::ref_ptr with target_ops. */ struct target_ops_ref_policy @@ -1349,10 +1346,9 @@ struct target_ops_ref_policy t->incref (); } - static void decref (target_ops *t) - { - decref_target (t); - } + /* Decrement the reference count on T, and, if the reference count + reaches zero, close the target. */ + static void decref (target_ops *t); }; /* A gdb::ref_ptr pointer to a target_ops. */ |