aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Burgess <aburgess@redhat.com>2022-05-09 16:49:03 +0100
committerAndrew Burgess <aburgess@redhat.com>2022-05-09 16:57:20 +0100
commit77399b529808626f764bcc347be0d6e8b6b167ce (patch)
treee5a99ba142836c9a71737f828d2d87edae7ed5ac
parentf3c75b2cbe88aa1f637d08317614bbeb2cbeecea (diff)
downloadgdb-77399b529808626f764bcc347be0d6e8b6b167ce.zip
gdb-77399b529808626f764bcc347be0d6e8b6b167ce.tar.gz
gdb-77399b529808626f764bcc347be0d6e8b6b167ce.tar.bz2
gdb/testsuite: fix occasional failure in gdb.mi/mi-multi-commands.exp
In bug PR gdb/29036, another failure was reported for the test gdb.mi/mi-multi-commands.exp. This test sends two commands to GDB as a single write, and then checks that both commands are executed. The problem that was encountered here is that the output of the first command, which looks like this: ^done,value="\"FIRST COMMAND\"" Is actually produced in parts, first the '^done' is printed, then the ',value="\"FIRST COMMAND\"" is printed. What was happening is that some characters from the second command were being echoed after the '^done' had been printed, but before the value part had been printed. To avoid this issue I've relaxed the pattern that checks for the first command a little. With this fix in place the occasional failure in this test is no longer showing up. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29036
-rw-r--r--gdb/testsuite/gdb.mi/mi-multi-commands.exp2
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.mi/mi-multi-commands.exp b/gdb/testsuite/gdb.mi/mi-multi-commands.exp
index d00e0aa..58187b1 100644
--- a/gdb/testsuite/gdb.mi/mi-multi-commands.exp
+++ b/gdb/testsuite/gdb.mi/mi-multi-commands.exp
@@ -100,7 +100,7 @@ proc run_test { args } {
set seen_second_message false
gdb_test_multiple "" "look for first command output, command length $i" -prompt "$mi_gdb_prompt" {
- -re "\\^done,value=\"\\\\\"FIRST COMMAND\\\\\"\"" {
+ -re "\\^done.*,value=\"\\\\\"FIRST COMMAND\\\\\"\"" {
set seen_first_message true
exp_continue
}