diff options
| author | Alan Modra <amodra@gmail.com> | 2019-05-06 09:13:53 +0930 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2019-05-06 11:41:28 +0930 |
| commit | e1cbf07ac4f8c8525dfadaa19bfb2997a2bfaad9 (patch) | |
| tree | b209e98f68947da6e5123e0907aacd3721dc71a1 | |
| parent | 334d91b9407c5f9f37f224b0f43551c01964eff1 (diff) | |
| download | gdb-e1cbf07ac4f8c8525dfadaa19bfb2997a2bfaad9.zip gdb-e1cbf07ac4f8c8525dfadaa19bfb2997a2bfaad9.tar.gz gdb-e1cbf07ac4f8c8525dfadaa19bfb2997a2bfaad9.tar.bz2 | |
PicoJava weak undefined symbols
This fixes the recently added ld-elf/pr24511 test failure on pj-elf.
Incidentally, pj-elf has failed its gas "pj" test since 2005-12-22
(git commit 54758c3e39). I think that makes the target ripe for
obsolescence.
bfd/
* elf32-pj.c (pj_elf_reloc): Don't report undefined weak as an error.
ld/
* testsuite/ld-undefined/weak-undef.exp: Don't xfail pj.
| -rw-r--r-- | bfd/ChangeLog | 4 | ||||
| -rw-r--r-- | bfd/elf32-pj.c | 1 | ||||
| -rw-r--r-- | ld/ChangeLog | 4 | ||||
| -rw-r--r-- | ld/testsuite/ld-undefined/weak-undef.exp | 1 |
4 files changed, 9 insertions, 1 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 0907098..f272ff8 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,9 @@ 2019-05-06 Alan Modra <amodra@gmail.com> + * elf32-pj.c (pj_elf_reloc): Don't report undefined weak as an error. + +2019-05-06 Alan Modra <amodra@gmail.com> + * reloc.c (BFD_RELOC_PPC64_TPREL16_HIGH, BFD_RELOC_PPC64_TPREL16_HIGHA), (BFD_RELOC_PPC64_DTPREL16_HIGH, BFD_RELOC_PPC64_DTPREL16_HIGHA): Sort before BFD_RELOC_PPC64_DTPREL16_HIGHESTA entry. diff --git a/bfd/elf32-pj.c b/bfd/elf32-pj.c index 712b352..c97d620 100644 --- a/bfd/elf32-pj.c +++ b/bfd/elf32-pj.c @@ -54,6 +54,7 @@ pj_elf_reloc (bfd *abfd, } if (symbol_in != NULL + && (symbol_in->flags & BSF_WEAK) == 0 && bfd_is_und_section (symbol_in->section)) return bfd_reloc_undefined; diff --git a/ld/ChangeLog b/ld/ChangeLog index d62a2c4..325392f 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,7 @@ +2019-05-06 Alan Modra <amodra@gmail.com> + + * testsuite/ld-undefined/weak-undef.exp: Don't xfail pj. + 2019-05-04 Alan Modra <amodra@gmail.com> * testsuite/ld-scripts/fill.d: Don't xfail m32c diff --git a/ld/testsuite/ld-undefined/weak-undef.exp b/ld/testsuite/ld-undefined/weak-undef.exp index 136c5db..73b6cf0 100644 --- a/ld/testsuite/ld-undefined/weak-undef.exp +++ b/ld/testsuite/ld-undefined/weak-undef.exp @@ -35,7 +35,6 @@ if { ![is_elf_format] && ![is_pecoff_format] } then { if {! [istarget i?86-*-*]} { setup_xfail *-*-pe* } - setup_xfail pj-*-* fail $testname } elseif {![is_remote host] && [which $objdump] == 0} then { unresolved $testname |