aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Filippov <jcmvbkbc@gmail.com>2021-04-23 02:03:36 -0700
committerMax Filippov <jcmvbkbc@gmail.com>2021-04-23 03:29:39 -0700
commitb3ea76397a07f5ec99432ed3df9ca848a6aab115 (patch)
treea2fbfc2fdfff73566082d54454d0d9336ec13282
parentc1cbb7d8a18374a815b0be38d41ee31748c54d70 (diff)
downloadgdb-b3ea76397a07f5ec99432ed3df9ca848a6aab115.zip
gdb-b3ea76397a07f5ec99432ed3df9ca848a6aab115.tar.gz
gdb-b3ea76397a07f5ec99432ed3df9ca848a6aab115.tar.bz2
opcodes: xtensa: display loaded literal value
Display literal value loaded with l32r opcode as a part of disassembly. This significantly simplifies reading of disassembly output. 2020-04-23 Max Filippov <jcmvbkbc@gmail.com> opcodes/ * xtensa-dis.c (print_xtensa_operand): For PC-relative operand of l32r fetch and display referenced literal value.
-rw-r--r--opcodes/ChangeLog5
-rw-r--r--opcodes/xtensa-dis.c20
2 files changed, 24 insertions, 1 deletions
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index c26cddf..bf495d0 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2020-04-23 Max Filippov <jcmvbkbc@gmail.com>
+
+ * xtensa-dis.c (print_xtensa_operand): For PC-relative operand
+ of l32r fetch and display referenced literal value.
+
2021-04-23 Max Filippov <jcmvbkbc@gmail.com>
* xtensa-dis.c (print_insn_xtensa): Set info->bytes_per_chunk
diff --git a/opcodes/xtensa-dis.c b/opcodes/xtensa-dis.c
index e38fc39..cfa058f 100644
--- a/opcodes/xtensa-dis.c
+++ b/opcodes/xtensa-dis.c
@@ -194,7 +194,8 @@ print_xtensa_operand (bfd_vma memaddr,
unsigned operand_val)
{
xtensa_isa isa = xtensa_default_isa;
- int signed_operand_val;
+ int signed_operand_val, status;
+ bfd_byte litbuf[4];
if (show_raw_fields)
{
@@ -216,6 +217,23 @@ print_xtensa_operand (bfd_vma memaddr,
&operand_val, memaddr);
info->target = operand_val;
(*info->print_address_func) (info->target, info);
+ /* Also display value loaded by L32R (but not if reloc exists,
+ those tend to be wrong): */
+ if ((info->flags & INSN_HAS_RELOC) == 0
+ && !strcmp ("l32r", xtensa_opcode_name (isa, opc)))
+ status = (*info->read_memory_func) (operand_val, litbuf, 4, info);
+ else
+ status = -1;
+
+ if (status == 0)
+ {
+ unsigned literal = bfd_get_bits (litbuf, 32,
+ info->endian == BFD_ENDIAN_BIG);
+
+ (*info->fprintf_func) (info->stream, " (");
+ (*info->print_address_func) (literal, info);
+ (*info->fprintf_func) (info->stream, ")");
+ }
}
else
{