aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Tromey <tom@tromey.com>2018-06-10 08:24:04 -0600
committerTom Tromey <tom@tromey.com>2018-06-10 09:58:34 -0600
commit4360561f5a326d9765cf1d95e5f779c5ab51045e (patch)
treea5631922d865744c18b45091a67ec6546a6c0273
parentd14b92bf8a7f4c57eb6c5fca559c7bbb8a747358 (diff)
downloadgdb-4360561f5a326d9765cf1d95e5f779c5ab51045e.zip
gdb-4360561f5a326d9765cf1d95e5f779c5ab51045e.tar.gz
gdb-4360561f5a326d9765cf1d95e5f779c5ab51045e.tar.bz2
Fix some missed "beneath" conversions
The buildbot pointed out that arm-linux-nat.c was not properly using "beneath" as a method. A search showed a few more places with this issue. Tested by the buildbot, though of course this only checked arm-linux-nat.c. Nevertheless I'm checking this in under the obvious rule. gdb/ChangeLog 2018-06-10 Tom Tromey <tom@tromey.com> * procfs.c (procfs_target::xfer_partial): Use "beneath" as a method. * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as a method. * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a method. * arm-linux-nat.c (arm_linux_nat_target::read_description): Use "beneath" as a method. * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description): Use "beneath" as a method.
-rw-r--r--gdb/ChangeLog13
-rw-r--r--gdb/arm-fbsd-nat.c2
-rw-r--r--gdb/arm-linux-nat.c4
-rw-r--r--gdb/go32-nat.c6
-rw-r--r--gdb/nto-procfs.c6
-rw-r--r--gdb/procfs.c6
6 files changed, 25 insertions, 12 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 37fd0f9..0e5c068 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,18 @@
2018-06-10 Tom Tromey <tom@tromey.com>
+ * procfs.c (procfs_target::xfer_partial): Use "beneath" as a
+ method.
+ * nto-procfs.c (nto_procfs_target::xfer_partial): Use "beneath" as
+ a method.
+ * go32-nat.c (go32_nat_target::xfer_partial): Use "beneath" as a
+ method.
+ * arm-linux-nat.c (arm_linux_nat_target::read_description): Use
+ "beneath" as a method.
+ * arm-fbsd-nat.c (arm_fbsd_nat_target::read_description):
+ Use "beneath" as a method.
+
+2018-06-10 Tom Tromey <tom@tromey.com>
+
* tracefile.c (struct trace_file_writer_deleter): New.
<operator()>: Rename from trace_file_writer_xfree.
(trace_file_writer_up): New typedef.
diff --git a/gdb/arm-fbsd-nat.c b/gdb/arm-fbsd-nat.c
index 34b1335..bc3e004 100644
--- a/gdb/arm-fbsd-nat.c
+++ b/gdb/arm-fbsd-nat.c
@@ -141,7 +141,7 @@ arm_fbsd_nat_target::read_description ()
desc = arm_fbsd_read_description_auxv (this);
if (desc == NULL)
- desc = this->beneath->read_description ();
+ desc = this->beneath ()->read_description ();
return desc;
}
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index 984bbe2..d0b4313 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -553,7 +553,7 @@ arm_linux_nat_target::read_description ()
if (target_auxv_search (this, AT_HWCAP, &arm_hwcap) != 1)
{
- return this->beneath->read_description ();
+ return this->beneath ()->read_description ();
}
if (arm_hwcap & HWCAP_IWMMXT)
@@ -586,7 +586,7 @@ arm_linux_nat_target::read_description ()
return result;
}
- return this->beneath->read_description ();
+ return this->beneath ()->read_description ();
}
/* Information describing the hardware breakpoint capabilities. */
diff --git a/gdb/go32-nat.c b/gdb/go32-nat.c
index 81e2ea4..f00e424 100644
--- a/gdb/go32-nat.c
+++ b/gdb/go32-nat.c
@@ -655,9 +655,9 @@ go32_nat_target::xfer_partial (enum target_object object,
return go32_xfer_memory (readbuf, writebuf, offset, len, xfered_len);
default:
- return this->beneath->xfer_partial (object, annex,
- readbuf, writebuf, offset, len,
- xfered_len);
+ return this->beneath ()->xfer_partial (object, annex,
+ readbuf, writebuf, offset, len,
+ xfered_len);
}
}
diff --git a/gdb/nto-procfs.c b/gdb/nto-procfs.c
index 63cae8a..a572fc1 100644
--- a/gdb/nto-procfs.c
+++ b/gdb/nto-procfs.c
@@ -995,9 +995,9 @@ nto_procfs_target::xfer_partial (enum target_object object,
}
/* Fallthru */
default:
- return this->beneath->xfer_partial (object, annex,
- readbuf, writebuf, offset, len,
- xfered_len);
+ return this->beneath ()->xfer_partial (object, annex,
+ readbuf, writebuf, offset, len,
+ xfered_len);
}
}
diff --git a/gdb/procfs.c b/gdb/procfs.c
index 83b3d7cc..082f5d4 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -2574,9 +2574,9 @@ procfs_target::xfer_partial (enum target_object object,
offset, len, xfered_len);
default:
- return this->beneath->xfer_partial (object, annex,
- readbuf, writebuf, offset, len,
- xfered_len);
+ return this->beneath ()->xfer_partial (object, annex,
+ readbuf, writebuf, offset, len,
+ xfered_len);
}
}