diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2016-02-18 03:13:19 -0800 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2016-02-18 03:13:51 -0800 |
commit | bf89386a862ace008f0152bca8bddf996d3993c8 (patch) | |
tree | d8e06697989cb979af0263ddaef268a4b79d5137 | |
parent | 06ea285dcbfb67189e46bee7f4f7c9b4140fc681 (diff) | |
download | gdb-bf89386a862ace008f0152bca8bddf996d3993c8.zip gdb-bf89386a862ace008f0152bca8bddf996d3993c8.tar.gz gdb-bf89386a862ace008f0152bca8bddf996d3993c8.tar.bz2 |
Always create dynamic sections for -E/--dynamic-list
In embedded environments, including boot loaders, the non-PIC executable
needs to export its symbols to modules loaded in the future. We should
always create dynamic sections for -E/--dynamic-list.
bfd/
PR ld/19617
* elflink.c (elf_link_add_object_symbols): Always create dynamic
sections for -E/--dynamic-list.
ld/
PR ld/19617
* testsuite/ld-elf/pr19617.s: New file.
* testsuite/ld-elf/pr19617a.d: Likewise.
* testsuite/ld-elf/pr19617b.d: Likewise.
* testsuite/ld-elf/pr19617c.d: Likewise.
-rw-r--r-- | bfd/ChangeLog | 6 | ||||
-rw-r--r-- | bfd/elflink.c | 7 | ||||
-rw-r--r-- | ld/ChangeLog | 8 | ||||
-rw-r--r-- | ld/testsuite/ld-elf/pr19617.s | 19 | ||||
-rw-r--r-- | ld/testsuite/ld-elf/pr19617a.d | 12 | ||||
-rw-r--r-- | ld/testsuite/ld-elf/pr19617b.d | 10 | ||||
-rw-r--r-- | ld/testsuite/ld-elf/pr19617c.d | 8 |
7 files changed, 68 insertions, 2 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index b5e5788..1c9e201 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2016-02-18 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/19617 + * elflink.c (elf_link_add_object_symbols): Always create dynamic + sections for -E/--dynamic-list. + 2016-02-17 H.J. Lu <hongjiu.lu@intel.com> * elf64-x86-64.c (elf_backend_omit_section_dynsym): New. Defined diff --git a/bfd/elflink.c b/bfd/elflink.c index ac03ce5..c7672ed 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -3598,11 +3598,14 @@ elf_link_add_object_symbols (bfd *abfd, struct bfd_link_info *info) /* If we are creating a shared library, create all the dynamic sections immediately. We need to attach them to something, so we attach them to this BFD, provided it is the right - format and is not from ld --just-symbols. FIXME: If there + format and is not from ld --just-symbols. Always create the + dynamic sections for -E/--dynamic-list. FIXME: If there are no input BFD's of the same format as the output, we can't make a shared library. */ if (!just_syms - && bfd_link_pic (info) + && (bfd_link_pic (info) + || info->export_dynamic + || info->dynamic) && is_elf_hash_table (htab) && info->output_bfd->xvec == abfd->xvec && !htab->dynamic_sections_created) diff --git a/ld/ChangeLog b/ld/ChangeLog index badac37..923f779 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,11 @@ +2016-02-18 H.J. Lu <hongjiu.lu@intel.com> + + PR ld/19617 + * testsuite/ld-elf/pr19617.s: New file. + * testsuite/ld-elf/pr19617a.d: Likewise. + * testsuite/ld-elf/pr19617b.d: Likewise. + * testsuite/ld-elf/pr19617c.d: Likewise. + 2016-02-18 Nick Clifton <nickc@redhat.com> * Makefile.am (CXX_FOR_TARGET): Check for the presence of an diff --git a/ld/testsuite/ld-elf/pr19617.s b/ld/testsuite/ld-elf/pr19617.s new file mode 100644 index 0000000..0acb8f5 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19617.s @@ -0,0 +1,19 @@ + .data + .global bar +bar: + .type bar,"object" + .long 0 + .text + .type start,"function" + .global start +start: + .type _start,"function" + .global _start +_start: + .type __start,"function" + .global __start +__start: + .type main,"function" + .global main +main: + .long 0 diff --git a/ld/testsuite/ld-elf/pr19617a.d b/ld/testsuite/ld-elf/pr19617a.d new file mode 100644 index 0000000..c8ebef0 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19617a.d @@ -0,0 +1,12 @@ +#source: pr19617.s +#ld: -E +#readelf : --dyn-syms --wide + +Symbol table '\.dynsym' contains [0-9]+ entries: + +Num: +Value +Size Type +Bind +Vis +Ndx Name + +0: 0+ +0 +NOTYPE +LOCAL +DEFAULT +UND + +#... + +[0-9]+: +[a-f0-9]+ +0 +FUNC +GLOBAL +DEFAULT +[0-9]+ +start +#... + +[0-9]+: +[a-f0-9]+ +0 +OBJECT +GLOBAL +DEFAULT +[0-9]+ +bar +#pass diff --git a/ld/testsuite/ld-elf/pr19617b.d b/ld/testsuite/ld-elf/pr19617b.d new file mode 100644 index 0000000..87bdffd --- /dev/null +++ b/ld/testsuite/ld-elf/pr19617b.d @@ -0,0 +1,10 @@ +#source: pr19617.s +#ld: --dynamic-list-data +#readelf : --dyn-syms --wide + +Symbol table '\.dynsym' contains [0-9]+ entries: + +Num: +Value +Size Type +Bind +Vis +Ndx Name + +0: 0+ +0 +NOTYPE +LOCAL +DEFAULT +UND + +#... + +[0-9]+: +[a-f0-9]+ +0 +OBJECT +GLOBAL +DEFAULT +[0-9]+ +bar +#pass diff --git a/ld/testsuite/ld-elf/pr19617c.d b/ld/testsuite/ld-elf/pr19617c.d new file mode 100644 index 0000000..1c758d8 --- /dev/null +++ b/ld/testsuite/ld-elf/pr19617c.d @@ -0,0 +1,8 @@ +#source: pr19617.s +#ld: --dynamic-list-data +#readelf : --dyn-syms --wide + +#failif +#... + +[0-9]+: +[a-f0-9]+ +0 +FUNC +GLOBAL +DEFAULT +[0-9]+ +start +#... |