diff options
| author | Richard Earnshaw <richard.earnshaw@arm.com> | 2006-09-08 10:30:27 +0000 |
|---|---|---|
| committer | Richard Earnshaw <richard.earnshaw@arm.com> | 2006-09-08 10:30:27 +0000 |
| commit | b0fead2b6ccb66d9992c06414159ddad063e2d6d (patch) | |
| tree | 3e767cd2b7a049655df5b449ac7fb419e8bb000a | |
| parent | 1a67c7076506dea67c6420ff20a1be02d102db5d (diff) | |
| download | gdb-b0fead2b6ccb66d9992c06414159ddad063e2d6d.zip gdb-b0fead2b6ccb66d9992c06414159ddad063e2d6d.tar.gz gdb-b0fead2b6ccb66d9992c06414159ddad063e2d6d.tar.bz2 | |
2006-09-08 Vladimir Prus <vladimir@codesourcery.com>
* elf32-arm.c (elf32_arm_swap_symbol_out): Remove
unconditional setting of low bit for Thumb symbol
mistakenly left behind after check for external
symbols was added. Fix comment typo.
| -rw-r--r-- | bfd/ChangeLog | 7 | ||||
| -rw-r--r-- | bfd/elf32-arm.c | 4 |
2 files changed, 8 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 88cff5c..fd79708 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2006-09-08 Vladimir Prus <vladimir@codesourcery.com> + + * elf32-arm.c (elf32_arm_swap_symbol_out): Remove + unconditional setting of low bit for Thumb symbol + mistakenly left behind after check for external + symbols was added. Fix comment typo. + 2006-09-07 H.J. Lu <hongjiu.lu@intel.com> * elf-bfd.h (elf_link_hash_entry): Add a dynamic field. diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c index 530ef99..8db3c8c 100644 --- a/bfd/elf32-arm.c +++ b/bfd/elf32-arm.c @@ -9385,14 +9385,12 @@ elf32_arm_swap_symbol_out (bfd *abfd, linker will simulate the work of dynamic linker of resolving symbols and will carry over the thumbness of found symbols to the output symbol table. It's not clear how it happens, but - the thumbness of underfined symbols can well be different at + the thumbness of undefined symbols can well be different at runtime, and writing '1' for them will be confusing for users and possibly for dynamic linker itself. */ newsym.st_value |= 1; } - - newsym.st_value |= 1; src = &newsym; } |