diff options
| author | Alan Modra <amodra@gmail.com> | 2005-01-20 06:46:41 +0000 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2005-01-20 06:46:41 +0000 |
| commit | c556cc9c6d052eef25dbb030a297cc0e204ba5c7 (patch) | |
| tree | 08cb030f8cc153c6578c37241412224b50d43432 | |
| parent | d17d003345eb4816548ff9da5c97fb7a76df714e (diff) | |
| download | gdb-c556cc9c6d052eef25dbb030a297cc0e204ba5c7.zip gdb-c556cc9c6d052eef25dbb030a297cc0e204ba5c7.tar.gz gdb-c556cc9c6d052eef25dbb030a297cc0e204ba5c7.tar.bz2 | |
PR gas/684
* read.c (s_incbin): Adjust default count for skip. Check validity
of count and skip rigorously.
| -rw-r--r-- | gas/ChangeLog | 6 | ||||
| -rw-r--r-- | gas/read.c | 8 |
2 files changed, 10 insertions, 4 deletions
diff --git a/gas/ChangeLog b/gas/ChangeLog index 41b654c..572d8e0 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2005-01-20 Alan Modra <amodra@bigpond.net.au> + + PR gas/684 + * read.c (s_incbin): Adjust default count for skip. Check validity + of count and skip rigorously. + 2005-01-19 Fred Fish <fnf@specifixinc.com> * config/tc-mips.c (dummy_opcode): Add init for new struct member. @@ -5000,13 +5000,13 @@ s_incbin (int x ATTRIBUTE_UNUSED) } file_len = ftell (binfile); - /* If a count was not specified use the size of the file. */ + /* If a count was not specified use the remainder of the file. */ if (count == 0) - count = file_len; + count = file_len - skip; - if (skip + count > file_len) + if (skip < 0 || count < 0 || file_len < 0 || skip + count > file_len) { - as_bad (_("skip (%ld) + count (%ld) larger than file size (%ld)"), + as_bad (_("skip (%ld) or count (%ld) invalid for file size (%ld)"), skip, count, file_len); goto done; } |