aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Alcock <nick.alcock@oracle.com>2021-03-18 12:37:52 +0000
committerNick Alcock <nick.alcock@oracle.com>2021-03-18 12:37:54 +0000
commit01cbfcba4bc74fb04904ad395a346549853bd189 (patch)
tree3b0bcca68e1b8c0be893a532da7128b0a84f83c7
parentbf4c3185a5a031824855a93c3476ae276236df12 (diff)
downloadgdb-01cbfcba4bc74fb04904ad395a346549853bd189.zip
gdb-01cbfcba4bc74fb04904ad395a346549853bd189.tar.gz
gdb-01cbfcba4bc74fb04904ad395a346549853bd189.tar.bz2
libctf: fix comment above ctf_dict_t
It is perfectly possible to have dynamically allocated data owned by a specific dict: you just have to teach ctf_serialize about it. libctf/ChangeLog 2021-03-18 Nick Alcock <nick.alcock@oracle.com> * ctf-impl.h (ctf_dict_t): Fix comment.
-rw-r--r--libctf/ChangeLog4
-rw-r--r--libctf/ctf-impl.h11
2 files changed, 10 insertions, 5 deletions
diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index bd2563d..58c0ed4 100644
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,5 +1,9 @@
2021-03-18 Nick Alcock <nick.alcock@oracle.com>
+ * ctf-impl.h (ctf_dict_t): Fix comment.
+
+2021-03-18 Nick Alcock <nick.alcock@oracle.com>
+
* ctf-create.c (symtypetab_delete_nonstatic_vars): Move
into ctf-serialize.c.
(ctf_symtab_skippable): Likewise.
diff --git a/libctf/ctf-impl.h b/libctf/ctf-impl.h
index 78a41ff..5567b4c 100644
--- a/libctf/ctf-impl.h
+++ b/libctf/ctf-impl.h
@@ -372,11 +372,12 @@ typedef struct ctf_dedup
ctf_dict_t typedef appears in <ctf-api.h> and declares a forward tag.
(A ctf_file_t typedef also appears there, for historical reasons.)
- NOTE: ctf_serialize() requires that everything inside of ctf_dict either be
- an immediate value, a pointer to dynamically allocated data *outside* of the
- ctf_dict itself, or a pointer to statically allocated data. If you add a
- pointer to ctf_dict that points to something within the ctf_dict itself, you
- must make corresponding changes to ctf_serialize(). */
+ NOTE: ctf_serialize requires that everything inside of ctf_dict either be an
+ immediate value, a pointer to dynamically allocated data *outside* of the
+ ctf_dict itself, a pointer to statically allocated data, or specially handled
+ in ctf_serialize. If you add a pointer to ctf_dict that points to something
+ within the ctf_dict itself, you must make corresponding changes to
+ ctf_serialize. */
struct ctf_dict
{