diff options
author | Pedro Alves <pedro@palves.net> | 2023-05-22 19:09:13 +0100 |
---|---|---|
committer | Pedro Alves <pedro@palves.net> | 2024-05-10 11:26:00 +0100 |
commit | f5e5342583c72869461b6f87563c9fc28e06a15a (patch) | |
tree | 53c17afd3fa436f01ea3b6206a9a5f5ee3f8b1c1 | |
parent | f428cac6151a5fb66812be52fd05b8eae8a164cd (diff) | |
download | gdb-f5e5342583c72869461b6f87563c9fc28e06a15a.zip gdb-f5e5342583c72869461b6f87563c9fc28e06a15a.tar.gz gdb-f5e5342583c72869461b6f87563c9fc28e06a15a.tar.bz2 |
Windows gdb+gdbserver: Make last_sig per-thread state
With non-stop mode, each thread is controlled independently of the
others, and each thread has its own independent reason for its last
stop.
Thus, any thread-specific state that is currently per-process must be
converted to per-thread state.
This patch converts windows_process_info::last_sig to per-thread
state, moving it to windows_thread_info instead.
This adjusts both native gdb and gdbserver.
Change-Id: Ice09a5d932c912210608d5af25e1898f823e3c99
-rw-r--r-- | gdb/nat/windows-nat.c | 8 | ||||
-rw-r--r-- | gdb/nat/windows-nat.h | 5 | ||||
-rw-r--r-- | gdb/windows-nat.c | 10 | ||||
-rw-r--r-- | gdbserver/win32-low.cc | 7 |
4 files changed, 15 insertions, 15 deletions
diff --git a/gdb/nat/windows-nat.c b/gdb/nat/windows-nat.c index cabc61f..5760431 100644 --- a/gdb/nat/windows-nat.c +++ b/gdb/nat/windows-nat.c @@ -369,8 +369,6 @@ windows_process_info::handle_exception (DEBUG_EVENT ¤t_event, memcpy (&siginfo_er, rec, sizeof siginfo_er); - last_sig = GDB_SIGNAL_0; - switch (code) { case EXCEPTION_ACCESS_VIOLATION: @@ -504,7 +502,11 @@ windows_process_info::handle_exception (DEBUG_EVENT ¤t_event, } if (ourstatus->kind () == TARGET_WAITKIND_STOPPED) - last_sig = ourstatus->sig (); + { + ptid_t ptid (current_event.dwProcessId, current_event.dwThreadId, 0); + windows_thread_info *th = find_thread (ptid); + th->last_sig = ourstatus->sig (); + } return result; diff --git a/gdb/nat/windows-nat.h b/gdb/nat/windows-nat.h index 73c828e..aab76d6 100644 --- a/gdb/nat/windows-nat.h +++ b/gdb/nat/windows-nat.h @@ -98,6 +98,10 @@ struct windows_thread_info thread. */ DEBUG_EVENT last_event {}; + /* The last signal reported for this thread, extracted out of + last_event. */ + enum gdb_signal last_sig = GDB_SIGNAL_0; + /* The context of the thread, including any manipulations. */ union { @@ -141,7 +145,6 @@ struct windows_process_info HANDLE handle = 0; DWORD process_id = 0; DWORD main_thread_id = 0; - enum gdb_signal last_sig = GDB_SIGNAL_0; /* Contents of $_siginfo */ EXCEPTION_RECORD siginfo_er {}; diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index bba8468..3b01f50 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -1349,6 +1349,7 @@ windows_per_inferior::continue_one_thread (windows_thread_info *th, } } th->resume (); + th->last_sig = GDB_SIGNAL_0; } /* Resume thread specified by ID, or all artificially suspended @@ -1449,7 +1450,7 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig) DEBUG_EXCEPT ("Cannot continue with signal %d here. " "Not stopped for EXCEPTION_DEBUG_EVENT", sig); } - else if (sig == windows_process.last_sig) + else if (sig == th->last_sig) continue_status = DBG_EXCEPTION_NOT_HANDLED; else #if 0 @@ -1473,11 +1474,9 @@ windows_nat_target::resume (ptid_t ptid, int step, enum gdb_signal sig) } #endif DEBUG_EXCEPT ("Can only continue with received signal %d.", - windows_process.last_sig); + th->last_sig); } - windows_process.last_sig = GDB_SIGNAL_0; - #ifdef __x86_64__ if (windows_process.wow64_process) { @@ -1590,8 +1589,6 @@ windows_nat_target::get_windows_debug_event } } - windows_process.last_sig = GDB_SIGNAL_0; - if ((options & TARGET_WNOHANG) != 0 && !m_debug_event_pending) { ourstatus->set_ignore (); @@ -1910,7 +1907,6 @@ windows_nat_target::do_initial_windows_stuff (DWORD pid, bool attaching) { struct inferior *inf; - windows_process.last_sig = GDB_SIGNAL_0; windows_process.open_process_used = 0; #ifdef __CYGWIN__ windows_process.cygwin_load_start = 0; diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 5608fb9..40575e3 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -302,7 +302,6 @@ do_initial_child_stuff (HANDLE proch, DWORD pid, int attached) { struct process_info *proc; - windows_process.last_sig = GDB_SIGNAL_0; windows_process.handle = proch; windows_process.process_id = pid; windows_process.main_thread_id = 0; @@ -415,6 +414,7 @@ continue_one_thread (thread_info *thread, int thread_id) } th->resume (); + th->last_sig = GDB_SIGNAL_0; } } } @@ -775,11 +775,11 @@ resume_one_thread (thread_info *thread, bool step, gdb_signal sig, "Not stopped for EXCEPTION_DEBUG_EVENT.\n", gdb_signal_to_string (sig))); } - else if (sig == windows_process.last_sig) + else if (sig == th->last_sig) *continue_status = DBG_EXCEPTION_NOT_HANDLED; else OUTMSG (("Can only continue with received signal %s.\n", - gdb_signal_to_string (windows_process.last_sig))); + gdb_signal_to_string (th->last_sig))); } win32_prepare_to_resume (th); @@ -980,7 +980,6 @@ get_child_debug_event (DWORD *continue_status, { ptid_t ptid; - windows_process.last_sig = GDB_SIGNAL_0; ourstatus->set_spurious (); *continue_status = DBG_CONTINUE; |