diff options
author | Simon Marchi <simon.marchi@ericsson.com> | 2015-07-27 15:49:24 -0400 |
---|---|---|
committer | Simon Marchi <simon.marchi@ericsson.com> | 2015-07-27 15:49:24 -0400 |
commit | 13e1dec8960122ec0329f74e5915503e14db5ea2 (patch) | |
tree | c32be51b725795b0fc6cbc188ab32072e3abee23 | |
parent | da33c9a7bff093e772a381bf9ab42d876089cdcf (diff) | |
download | gdb-13e1dec8960122ec0329f74e5915503e14db5ea2.zip gdb-13e1dec8960122ec0329f74e5915503e14db5ea2.tar.gz gdb-13e1dec8960122ec0329f74e5915503e14db5ea2.tar.bz2 |
gdb.mi/mi-pending.c: Return NULL instead of nothing in thread function
Using gcc 5.2 (maybe other versions as well), building mi-pending.c gives
these warnings:
./gdb.mi/mi-pending.c: In function ‘thread_func’:
./gdb.mi/mi-pending.c:34:5: warning: ‘return’ with no value, in function returning non-void
return;
^
./gdb.mi/mi-pending.c:38:5: warning: ‘return’ with no value, in function returning non-void
return;
^
gdb_compile_pthreads assumes that the build was successful only if there
is no output. These warnings therefore make gdb_compile_pthreads think
that the build failed, and the test doesn't run.
The easy fix is to replace the "return" with "return NULL". I am
pushing this as obvious.
gdb/testsuite/ChangeLog:
* gdb.mi/mi-pending.c (thread_func): Replace return with return
NULL.
-rw-r--r-- | gdb/testsuite/ChangeLog | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.mi/mi-pending.c | 4 |
2 files changed, 6 insertions, 2 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 73bc2b6..fd7c09c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2015-07-27 Simon Marchi <simon.marchi@ericsson.com> + * gdb.mi/mi-pending.c (thread_func): Replace return with return NULL. + +2015-07-27 Simon Marchi <simon.marchi@ericsson.com> + * gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail. 2015-07-27 Patrick Palka <patrick@parcs.ath.cx> diff --git a/gdb/testsuite/gdb.mi/mi-pending.c b/gdb/testsuite/gdb.mi/mi-pending.c index 248c7a8..2f3464e 100644 --- a/gdb/testsuite/gdb.mi/mi-pending.c +++ b/gdb/testsuite/gdb.mi/mi-pending.c @@ -31,11 +31,11 @@ thread_func (void* arg) h = dlopen (libname, RTLD_LAZY); /* set breakpoint here */ if (h == NULL) - return; + return NULL; p_func = dlsym (h, "pendfunc3"); if (p_func == NULL) - return; + return NULL; (*p_func) (); } |