diff options
author | Pedro Alves <pedro@palves.net> | 2020-07-04 19:31:21 +0100 |
---|---|---|
committer | Pedro Alves <palves@redhat.com> | 2020-07-06 19:57:34 +0100 |
commit | f7bf4732bb5a8d2b27c3ab7428f359481cffe970 (patch) | |
tree | abd9636baf72e208b7a761fd7aaccb92c3b66bfd | |
parent | ce502e47c0b5333703dfa4b6d1268ca65a0b2926 (diff) | |
download | gdb-f7bf4732bb5a8d2b27c3ab7428f359481cffe970.zip gdb-f7bf4732bb5a8d2b27c3ab7428f359481cffe970.tar.gz gdb-f7bf4732bb5a8d2b27c3ab7428f359481cffe970.tar.bz2 |
Avoid constant stream of TARGET_WAITKIND_NO_RESUMED
If we hit the synchronous execution command case described by
handle_no_resumed, and handle_no_resumed determines that the event
should be ignored, because it found a thread that is executing, we end
up in prepare_to_wait.
There, if the current target is not registered in the event loop right
now, we call mark_infrun_async_event_handler. With that event handler
marked, the event loop calls again into fetch_inferior_event, which
calls target_wait, which returns TARGET_WAITKIND_NO_RESUMED, and we
end up in handle_no_resumed, again ignoring the event and marking
infrun_async_event_handler. The result is that GDB is now always
keeping the CPU 100% busy in this loop, even though it continues to be
able to react to input and to real target events, because we still go
through the event-loop.
The problem is that marking of the infrun_async_event_handler in
prepare_to_wait. That is there to handle targets that don't support
asynchronous execution. So the correct predicate is whether async
execution is supported, not whether the target is async right now.
gdb/ChangeLog:
PR gdb/26199
* infrun.c (prepare_to_wait): Check target_can_async_p instead of
target_is_async_p.
-rw-r--r-- | gdb/infrun.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/gdb/infrun.c b/gdb/infrun.c index 6b655d4..a01e096 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -8116,7 +8116,11 @@ prepare_to_wait (struct execution_control_state *ecs) ecs->wait_some_more = 1; - if (!target_is_async_p ()) + /* If the target can't async, emulate it by marking the infrun event + handler such that as soon as we get back to the event-loop, we + immediately end up in fetch_inferior_event again calling + target_wait. */ + if (!target_can_async_p ()) mark_infrun_async_event_handler (); } |