diff options
| author | Doug Evans <dje@google.com> | 2012-01-26 23:22:23 +0000 |
|---|---|---|
| committer | Doug Evans <dje@google.com> | 2012-01-26 23:22:23 +0000 |
| commit | 7e0820728645f32a8809eea1f76b9669695490f2 (patch) | |
| tree | ac4417947994e8351dce5aeac8c3bc7843480f6d | |
| parent | 3c064588bb4c021bc97841c5e19f944d7988309c (diff) | |
| download | gdb-7e0820728645f32a8809eea1f76b9669695490f2.zip gdb-7e0820728645f32a8809eea1f76b9669695490f2.tar.gz gdb-7e0820728645f32a8809eea1f76b9669695490f2.tar.bz2 | |
* symtab.c (lookup_symbol_in_language): Improve comment.
(lookup_symbol_aux): Fix comment.
| -rw-r--r-- | gdb/ChangeLog | 3 | ||||
| -rw-r--r-- | gdb/symtab.c | 12 |
2 files changed, 8 insertions, 7 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1699332..41b77bb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,8 @@ 2012-01-26 Doug Evans <dje@google.com> + * symtab.c (lookup_symbol_in_language): Improve comment. + (lookup_symbol_aux): Fix comment. + * psymtab.c (add_psymbol_to_list): Result is now "void". * psympriv.h (add_psymbol_to_list): Update. diff --git a/gdb/symtab.c b/gdb/symtab.c index d3e7b04..04db576 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -1170,11 +1170,11 @@ demangle_for_lookup (const char *name, enum language lang, BLOCK_FOUND is set to the block in which NAME is found (in the case of a field of `this', value_of_this sets BLOCK_FOUND to the proper value.) */ -/* This function has a bunch of loops in it and it would seem to be - attractive to put in some QUIT's (though I'm not really sure - whether it can run long enough to be really important). But there +/* This function (or rather its subordinates) have a bunch of loops and + it would seem to be attractive to put in some QUIT's (though I'm not really + sure whether it can run long enough to be really important). But there are a few calls for which it would appear to be bad news to quit - out of here: find_proc_desc in alpha-tdep.c and mips-tdep.c. (Note + out of here: e.g., find_proc_desc in alpha-mdebug-tdep.c. (Note that there is C++ code below which can error(), but that probably doesn't affect these calls since they are looking for a known variable and thus can probably assume it will never hit the C++ @@ -1234,9 +1234,7 @@ lookup_language_this (const struct language_defn *lang, } /* Behave like lookup_symbol except that NAME is the natural name - of the symbol that we're looking for and, if LINKAGE_NAME is - non-NULL, ensure that the symbol's linkage name matches as - well. */ + (e.g., demangled name) of the symbol that we're looking for. */ static struct symbol * lookup_symbol_aux (const char *name, const struct block *block, |