Simplify add_target_sections_of_objfile

Now that target_section_table uses std::vector,
add_target_sections_of_objfile does not need to loop twice.  This
patch simplifies this code to have just a single loop.  Also, the
passed-in objfile can never be NULL, so this changes this function to
assert that.

gdb/ChangeLog
2020-10-12  Tom Tromey  <tom@tromey.com>

	* exec.c (add_target_sections_of_objfile): Simplify.

2 files changed, 5 insertions, 13 deletions

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7a66a4d..6cf0b26 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
 2020-10-12  Tom Tromey  <tom@tromey.com>
 
+	* exec.c (add_target_sections_of_objfile): Simplify.
+
+2020-10-12  Tom Tromey  <tom@tromey.com>
+
 	* solib.c (solib_map_sections): Update.
 	* record-full.c (record_full_core_open_1): Update.
 	* exec.h (build_section_table): Return a target_section_table.
diff --git a/gdb/exec.c b/gdb/exec.c
index d4b9b7b..43385fe 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -661,26 +661,14 @@ add_target_sections_of_objfile (struct objfile *objfile)
 {
   struct target_section_table *table = current_target_sections;
   struct obj_section *osect;
-  unsigned count = 0;
 
-  if (objfile == NULL)
-    return;
+  gdb_assert (objfile != nullptr);
 
   /* Compute the number of sections to add.  */
   ALL_OBJFILE_OSECTIONS (objfile, osect)
     {
       if (bfd_section_size (osect->the_bfd_section) == 0)
 	continue;
-      count++;
-    }
-
-  if (count == 0)
-    return;
-
-  ALL_OBJFILE_OSECTIONS (objfile, osect)
-    {
-      if (bfd_section_size (osect->the_bfd_section) == 0)
-	continue;
 
       table->sections.emplace_back ();
       target_section &ts = table->sections.back ();