aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKeith Seitz <keiths@redhat.com>2017-10-17 14:15:36 -0700
committerKeith Seitz <keiths@redhat.com>2017-10-18 10:14:01 -0700
commit3753468682a9c7982b6eba0fca58fbfc1cd5b9fb (patch)
treef6b738cf2c2a0640e15f8d1790133004e828f9ca
parent2a6969e1738859ea8c12837fb0cba3845bc87ceb (diff)
downloadgdb-3753468682a9c7982b6eba0fca58fbfc1cd5b9fb.zip
gdb-3753468682a9c7982b6eba0fca58fbfc1cd5b9fb.tar.gz
gdb-3753468682a9c7982b6eba0fca58fbfc1cd5b9fb.tar.bz2
Issue complaint instead of assert for invalid/unhandled DW_AT_accessibility
A previous patch called gdb_assert_not_reached whenever reading the accessibility of a nested typedef definition. Wisely, Pedro has asked me not do this. This patch changes the previous one so that it issues a complaint instead. gdb/ChangeLog: * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled DW_AT_accessibility.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/dwarf2read.c3
2 files changed, 7 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 097b0de..b588641 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-10-18 Keith Seitz <keiths@redhat.com>
+
+ * dwarf2read.c (dwarf2_add_typedef): Issue a complaint on unhandled
+ DW_AT_accessibility.
+
2017-10-18 Yao Qi <yao.qi@linaro.org>
* features/tic6x-c62x-linux.c: Remove.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index f27d9b9..686fa3f 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -13131,7 +13131,8 @@ dwarf2_add_typedef (struct field_info *fip, struct die_info *die,
fp->is_protected = 1;
break;
default:
- gdb_assert_not_reached ("unexpected accessibility attribute");
+ complaint (&symfile_complaints,
+ _("Unhandled DW_AT_accessibility value (%x)"), accessibility);
}
new_field->next = fip->typedef_field_list;