aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Cagney <cagney@redhat.com>2003-06-01 22:30:30 +0000
committerAndrew Cagney <cagney@redhat.com>2003-06-01 22:30:30 +0000
commit1fd4ae226388e78eba387080d1bb8b13fa08fb93 (patch)
tree245020fe37235327fbb24fe8eb734970153ccec1
parent44d8858367e916cf2e56c5d4e1f857ac9ca3d87f (diff)
downloadgdb-1fd4ae226388e78eba387080d1bb8b13fa08fb93.zip
gdb-1fd4ae226388e78eba387080d1bb8b13fa08fb93.tar.gz
gdb-1fd4ae226388e78eba387080d1bb8b13fa08fb93.tar.bz2
Oops, really commit. Part of:
* infcall.c (call_function_by_hand): Update comment on DEPRECATED_DUMMY_WRITE_SP. * mips-tdep.c (mips_gdbarch_init): Do not set deprecated_dummy_write_sp. (mips_eabi_push_dummy_call): Set the SP register. (mips_o64_push_dummy_call): Set the SP register. (mips_o32_push_dummy_call): Set the SP register. (mips_n32n64_push_dummy_call): Set the SP register.
-rw-r--r--gdb/infcall.c19
1 files changed, 10 insertions, 9 deletions
diff --git a/gdb/infcall.c b/gdb/infcall.c
index 82c18ae..546e33c 100644
--- a/gdb/infcall.c
+++ b/gdb/infcall.c
@@ -809,15 +809,16 @@ You must use a pointer to function type variable. Command ignored.", arg_name);
if (struct_return && DEPRECATED_STORE_STRUCT_RETURN_P ())
DEPRECATED_STORE_STRUCT_RETURN (struct_addr, sp);
- /* Write the stack pointer. This is here because the statements above
- might fool with it. On SPARC, this write also stores the register
- window into the right place in the new stack frame, which otherwise
- wouldn't happen. (See store_inferior_registers in sparc-nat.c.) */
- /* NOTE: cagney/2003-03-23: Disable this code when there is a
- push_dummy_call() method. Since that method will have already
- stored the stack pointer (as part of creating the fake call
- frame), and none of the code following that code adjusts the
- stack-pointer value, the below call is entirely redundant. */
+ /* Write the stack pointer. This is here because the statements
+ above might fool with it. On SPARC, this write also stores the
+ register window into the right place in the new stack frame,
+ which otherwise wouldn't happen (see store_inferior_registers in
+ sparc-nat.c). */
+ /* NOTE: cagney/2003-03-23: Since the architecture method
+ push_dummy_call() should have already stored the stack pointer
+ (as part of creating the fake call frame), and none of the code
+ following that call adjusts the stack-pointer value, the below
+ call is entirely redundant. */
if (DEPRECATED_DUMMY_WRITE_SP_P ())
DEPRECATED_DUMMY_WRITE_SP (sp);