diff options
| author | Tom Tromey <tom@tromey.com> | 2023-02-17 19:55:50 -0500 |
|---|---|---|
| committer | Tom Tromey <tom@tromey.com> | 2023-02-21 12:36:15 -0700 |
| commit | 3592bebbbf6b27732effc49bd6a73b0bd5af4df4 (patch) | |
| tree | 525112bd0dfe65cad67cebc728186110e1e84f41 | |
| parent | 4c9066e322f46faf9d753be6ff3e6a09ae668f86 (diff) | |
| download | gdb-3592bebbbf6b27732effc49bd6a73b0bd5af4df4.zip gdb-3592bebbbf6b27732effc49bd6a73b0bd5af4df4.tar.gz gdb-3592bebbbf6b27732effc49bd6a73b0bd5af4df4.tar.bz2 | |
Issue error on erroneous expression
A while back I discovered that this does not issue an error:
(gdb) p $x = (void * ) 57
$3 = (void *) 0x39
(gdb) p $x + 7 = 3
$6 = (void *) 0x3
This patch fixes the bug.
Regression tested on x86-64 Fedora 36.
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312
| -rw-r--r-- | gdb/testsuite/gdb.base/gdbvars.exp | 8 | ||||
| -rw-r--r-- | gdb/valarith.c | 2 |
2 files changed, 9 insertions, 1 deletions
diff --git a/gdb/testsuite/gdb.base/gdbvars.exp b/gdb/testsuite/gdb.base/gdbvars.exp index ced77aa..cb6656c 100644 --- a/gdb/testsuite/gdb.base/gdbvars.exp +++ b/gdb/testsuite/gdb.base/gdbvars.exp @@ -66,6 +66,14 @@ proc test_convenience_variables {} { gdb_test "print \$arr = {0, 1, 2, 3}" \ " = \\{0, 1, 2, 3\\}" \ "Set convenience variable to different array value" + + gdb_test "print \$ptr = (void *) 7" \ + " = \\(void \\*\\) 0x7" \ + "set convenience variable to pointer value" + # This used to "succeed". + gdb_test "print \$ptr + 23 = 97" \ + "Left operand of assignment is not an lvalue." \ + "reject invalid assignment" } proc test_convenience_functions {} { diff --git a/gdb/valarith.c b/gdb/valarith.c index 0ab684a..a6a5f51 100644 --- a/gdb/valarith.c +++ b/gdb/valarith.c @@ -93,7 +93,7 @@ value_ptradd (struct value *arg1, LONGEST arg2) result = value_from_pointer (valptrtype, value_as_address (arg1) + sz * arg2); - if (result->lval () != lval_internalvar) + if (arg1->lval () != lval_internalvar) result->set_component_location (arg1); return result; } |