diff options
author | Andrew Burgess <aburgess@redhat.com> | 2022-11-14 14:22:46 +0000 |
---|---|---|
committer | Andrew Burgess <aburgess@redhat.com> | 2022-11-28 21:04:09 +0000 |
commit | 6ca2ea063a71d6e2742096f980c2607e9d413cf5 (patch) | |
tree | 6f59c4d1e7b77f69734bba8ddadc570b43010e12 | |
parent | bde43e8dbeaf4c9b05514f0c749623db453747bb (diff) | |
download | gdb-6ca2ea063a71d6e2742096f980c2607e9d413cf5.zip gdb-6ca2ea063a71d6e2742096f980c2607e9d413cf5.tar.gz gdb-6ca2ea063a71d6e2742096f980c2607e9d413cf5.tar.bz2 |
gdb/testsuite: remove use of then keyword from gdb.disasm/*.exp
The canonical form of 'if' in modern TCL is 'if {} {}'. But there's
still a bunch of places in the testsuite where we make use of the
'then' keyword, and sometimes these get copies into new tests, which
just spreads poor practice.
This commit removes all use of the 'then' keyword from the gdb.disasm/
test script directory.
There should be no changes in what is tested after this commit.
-rw-r--r-- | gdb/testsuite/gdb.disasm/t01_mov.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t02_mova.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t03_add.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t04_sub.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t05_cmp.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t06_ari2.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t07_ari3.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t08_or.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t09_xor.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t10_and.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t11_logs.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t12_bit.exp | 4 | ||||
-rw-r--r-- | gdb/testsuite/gdb.disasm/t13_otr.exp | 4 |
13 files changed, 26 insertions, 26 deletions
diff --git a/gdb/testsuite/gdb.disasm/t01_mov.exp b/gdb/testsuite/gdb.disasm/t01_mov.exp index c9efa34..2e29bac 100644 --- a/gdb/testsuite/gdb.disasm/t01_mov.exp +++ b/gdb/testsuite/gdb.disasm/t01_mov.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t02_mova.exp b/gdb/testsuite/gdb.disasm/t02_mova.exp index 3fcb0be..67d3d5f 100644 --- a/gdb/testsuite/gdb.disasm/t02_mova.exp +++ b/gdb/testsuite/gdb.disasm/t02_mova.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t03_add.exp b/gdb/testsuite/gdb.disasm/t03_add.exp index 0a5a914..b2f2289 100644 --- a/gdb/testsuite/gdb.disasm/t03_add.exp +++ b/gdb/testsuite/gdb.disasm/t03_add.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t04_sub.exp b/gdb/testsuite/gdb.disasm/t04_sub.exp index 4f4353e..5ac5829 100644 --- a/gdb/testsuite/gdb.disasm/t04_sub.exp +++ b/gdb/testsuite/gdb.disasm/t04_sub.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t05_cmp.exp b/gdb/testsuite/gdb.disasm/t05_cmp.exp index 534f816..a1c7041 100644 --- a/gdb/testsuite/gdb.disasm/t05_cmp.exp +++ b/gdb/testsuite/gdb.disasm/t05_cmp.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t06_ari2.exp b/gdb/testsuite/gdb.disasm/t06_ari2.exp index ab5ffdd..c7de733 100644 --- a/gdb/testsuite/gdb.disasm/t06_ari2.exp +++ b/gdb/testsuite/gdb.disasm/t06_ari2.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t07_ari3.exp b/gdb/testsuite/gdb.disasm/t07_ari3.exp index 810dc0e..7937925 100644 --- a/gdb/testsuite/gdb.disasm/t07_ari3.exp +++ b/gdb/testsuite/gdb.disasm/t07_ari3.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t08_or.exp b/gdb/testsuite/gdb.disasm/t08_or.exp index 5ade4eb..fdfa0a1 100644 --- a/gdb/testsuite/gdb.disasm/t08_or.exp +++ b/gdb/testsuite/gdb.disasm/t08_or.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t09_xor.exp b/gdb/testsuite/gdb.disasm/t09_xor.exp index 8c8f584..7e24675 100644 --- a/gdb/testsuite/gdb.disasm/t09_xor.exp +++ b/gdb/testsuite/gdb.disasm/t09_xor.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t10_and.exp b/gdb/testsuite/gdb.disasm/t10_and.exp index c096737..5650aeb 100644 --- a/gdb/testsuite/gdb.disasm/t10_and.exp +++ b/gdb/testsuite/gdb.disasm/t10_and.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t11_logs.exp b/gdb/testsuite/gdb.disasm/t11_logs.exp index 7511b84..2b58273 100644 --- a/gdb/testsuite/gdb.disasm/t11_logs.exp +++ b/gdb/testsuite/gdb.disasm/t11_logs.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t12_bit.exp b/gdb/testsuite/gdb.disasm/t12_bit.exp index 1020986..e584121 100644 --- a/gdb/testsuite/gdb.disasm/t12_bit.exp +++ b/gdb/testsuite/gdb.disasm/t12_bit.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } diff --git a/gdb/testsuite/gdb.disasm/t13_otr.exp b/gdb/testsuite/gdb.disasm/t13_otr.exp index 70fbd13..61b300f 100644 --- a/gdb/testsuite/gdb.disasm/t13_otr.exp +++ b/gdb/testsuite/gdb.disasm/t13_otr.exp @@ -30,12 +30,12 @@ set asm-flags "" set link-flags "-m h8300sxelf" -if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} then { +if {[target_assemble $srcfile $objfile "${asm-flags}"] != ""} { untested "failed to assemble" return -1 } -if {[target_link $objfile $binfile "${link-flags}"] != ""} then { +if {[target_link $objfile $binfile "${link-flags}"] != ""} { untested "failed to link" return -1 } |