diff options
| author | Simon Marchi <simon.marchi@ericsson.com> | 2014-11-26 13:03:57 -0500 |
|---|---|---|
| committer | Simon Marchi <simon.marchi@ericsson.com> | 2014-11-27 09:27:08 -0500 |
| commit | f28a0564dded48d14df749f11f8ce7638d96db12 (patch) | |
| tree | 1775d110720796f04c09ffb3896f55ba1d7b0005 | |
| parent | 1036838a771b96ad9428e8fc7ecc45d3d8e056ce (diff) | |
| download | gdb-f28a0564dded48d14df749f11f8ce7638d96db12.zip gdb-f28a0564dded48d14df749f11f8ce7638d96db12.tar.gz gdb-f28a0564dded48d14df749f11f8ce7638d96db12.tar.bz2 | |
Fix test always passing in python/py-linetable.exp
The following test is found in python/py-linetable.exp:
gdb_test "python print sorted(fset)" \
"\[20L, 21L, 22L, 24L, 25L, 28L, 29L, 30L, 32L, 33L, 37L, 39L, 40L, 42L, 44L, 45L, 46L\].*" \
"Test frozen set contains line numbers"
I noticed that it passed when using Python 3, even though it should fail
because of the missing parentheses for the call print.
There needs to be more escaping of the square brackets. Currently, it is
interpreted as "any one character from this big list of characters,
followed by .*". When adding the required amount of backslashes, the
test starts failing as it should.
Moreover, both in Python 2.7 and Python 3.3 the numbers don't have the L
suffix, so now the test fails because of that. Anybody knows why they
were there in the first place? I just tested with Python 2.4 and there
are no Ls.
gdb/testsuite/ChangeLog:
* gdb.python/py-linetable.exp: Escape properly sorted(fset)
test expected output. Add parentheses for the call to print.
Remove L suffix from integers.
Signed-off-by: Simon Marchi <simon.marchi@ericsson.com>
| -rw-r--r-- | gdb/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.python/py-linetable.exp | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index a21e88e..16fa87d 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2014-11-27 Simon Marchi <simon.marchi@ericsson.com> + + * gdb.python/py-linetable.exp: Escape properly sorted(fset) + test expected output. Add parentheses for the call to print. + Remove L suffix from integers. + 2014-11-26 Doug Evans <dje@google.com> * gdb.dwarf2/dw2-op-out-param.S: Fix comment. diff --git a/gdb/testsuite/gdb.python/py-linetable.exp b/gdb/testsuite/gdb.python/py-linetable.exp index 682b5b7..2f24ab4 100644 --- a/gdb/testsuite/gdb.python/py-linetable.exp +++ b/gdb/testsuite/gdb.python/py-linetable.exp @@ -60,8 +60,8 @@ gdb_test "python print lt.line(1)" "None" \ # Test gdb.Linetable.sourcelines () gdb_py_test_silent_cmd "python fset = lt.source_lines()" \ "Get all source lines into a frozen set" 0 -gdb_test "python print sorted(fset)" \ - "\[20L, 21L, 22L, 24L, 25L, 28L, 29L, 30L, 32L, 33L, 37L, 39L, 40L, 42L, 44L, 45L, 46L\].*" \ +gdb_test "python print (sorted(fset))" \ + "\\\[20, 21, 22, 24, 25, 28, 29, 30, 32, 33, 37, 39, 40, 42, 44, 45, 46\\\].*" \ "Test frozen set contains line numbers" # Test gdb.Linetable.has_line () |