aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Marchi <simon.marchi@ericsson.com>2017-01-12 11:15:01 -0500
committerSimon Marchi <simon.marchi@ericsson.com>2017-01-12 11:15:02 -0500
commit3015c06465584a437261c65a397fbd8f1a71aae7 (patch)
tree51039d7ed1c7ace87caa4177f39aa8721844a399
parentfde1b17d37fd5557a22948d500bb5f4b6ef5d089 (diff)
downloadgdb-3015c06465584a437261c65a397fbd8f1a71aae7.zip
gdb-3015c06465584a437261c65a397fbd8f1a71aae7.tar.gz
gdb-3015c06465584a437261c65a397fbd8f1a71aae7.tar.bz2
Update comment in remote_can_async_p
I find this comment counter intuitive, and it probably predates the always-target-async change. AFAIK, remote will always be async, unless the user explicitly prevents it with "maint set target-async off". gdb/ChangeLog: * remote.c (remote_can_async_p): Update comment.
-rw-r--r--gdb/ChangeLog4
-rw-r--r--gdb/remote.c3
2 files changed, 6 insertions, 1 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 27aa394..bf0930f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,9 @@
2017-01-12 Simon Marchi <simon.marchi@ericsson.com>
+ * remote.c (remote_can_async_p): Update comment.
+
+2017-01-12 Simon Marchi <simon.marchi@ericsson.com>
+
* linux-nat.c (linux_nat_can_async_p): Update comment.
2017-01-12 Simon Marchi <simon.marchi@ericsson.com>
diff --git a/gdb/remote.c b/gdb/remote.c
index 837b9ee..c73c30a 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13653,8 +13653,9 @@ remote_can_async_p (struct target_ops *ops)
{
struct remote_state *rs = get_remote_state ();
+ /* We don't go async if the user has explicitly prevented it with the
+ "maint set target-async" command. */
if (!target_async_permitted)
- /* We only enable async when the user specifically asks for it. */
return 0;
/* We're async whenever the serial device is. */