diff options
| author | Alan Modra <amodra@gmail.com> | 2013-11-05 12:38:51 +1030 |
|---|---|---|
| committer | Alan Modra <amodra@gmail.com> | 2013-11-05 12:44:54 +1030 |
| commit | dba6fa9bce92c9f9fcca07269ac8443797bd9338 (patch) | |
| tree | 1377f3c3fcb91012d1d5c5361a1e2a0cdc820a5a | |
| parent | 33e44f2eb27d78f57ed83d11f04652691d896a6f (diff) | |
| download | gdb-dba6fa9bce92c9f9fcca07269ac8443797bd9338.zip gdb-dba6fa9bce92c9f9fcca07269ac8443797bd9338.tar.gz gdb-dba6fa9bce92c9f9fcca07269ac8443797bd9338.tar.bz2 | |
Hide ppc64 .TOC. from --export-dynamic
I can't see any good reason why anyone would want a dynamic .TOC., so
hide it in a way that is respected by _bfd_elf_export_symbol. This
also fixes an abort in relocate_section on not finding sreloc for .TOC.
* elf64-ppc.c (ppc64_elf_func_desc_adjust): Make .TOC. defined and
hidden.
(ppc64_elf_set_toc): Adjust.
| -rw-r--r-- | bfd/ChangeLog | 6 | ||||
| -rw-r--r-- | bfd/elf64-ppc.c | 15 |
2 files changed, 18 insertions, 3 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index d6b9989..ac78036 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,5 +1,11 @@ 2013-11-05 Alan Modra <amodra@gmail.com> + * elf64-ppc.c (ppc64_elf_func_desc_adjust): Make .TOC. defined and + hidden. + (ppc64_elf_set_toc): Adjust. + +2013-11-05 Alan Modra <amodra@gmail.com> + * elf64-ppc.c (struct ppc_link_hash_table): Remove got, plt, relplt, iplt, reliplt. Update all references to use elf.sgot, elf.splt, elf.srelplt, elf.iplt and elf.irelplt. diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index adc285f..136887f 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -6837,7 +6837,18 @@ ppc64_elf_func_desc_adjust (bfd *obfd ATTRIBUTE_UNUSED, if (!info->relocatable && htab->elf.hgot != NULL) - _bfd_elf_link_hash_hide_symbol (info, htab->elf.hgot, TRUE); + { + _bfd_elf_link_hash_hide_symbol (info, htab->elf.hgot, TRUE); + /* Make .TOC. defined so as to prevent it being made dynamic. + The wrong value here is fixed later in ppc64_elf_set_toc. */ + htab->elf.hgot->type = STT_OBJECT; + htab->elf.hgot->root.type = bfd_link_hash_defined; + htab->elf.hgot->root.u.def.value = 0; + htab->elf.hgot->root.u.def.section = bfd_abs_section_ptr; + htab->elf.hgot->def_regular = 1; + htab->elf.hgot->other = ((htab->elf.hgot->other & ~ELF_ST_VISIBILITY (-1)) + | STV_HIDDEN); + } if (htab->sfpr == NULL) /* We don't have any relocs. */ @@ -12329,8 +12340,6 @@ ppc64_elf_set_toc (struct bfd_link_info *info, bfd *obfd) if (htab != NULL && htab->elf.hgot != NULL) { - htab->elf.hgot->type = STT_OBJECT; - htab->elf.hgot->root.type = bfd_link_hash_defined; htab->elf.hgot->root.u.def.value = TOC_BASE_OFF; htab->elf.hgot->root.u.def.section = s; } |